68752[TASK] Unify SVG toolbar generation
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Hader +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeElement.ts4+5 −43
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageTree.ts+0 −3
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageTreeContainer.ts+4 −60
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SvgTree.ts+61 −6
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js+10 −12
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTreeContainer.js+3 −14
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js+13 −2
Review log 1119
-
Benni Mack uploaded patch set 1 04/08/21, 23:46
-
TYPO3com voted on patch set 1 V +1 04/08/21, 23:53 Completed build in 06m 45s on Thu, 8 Apr, 11:53 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10567
-
core-ci voted on patch set 1 V +1 04/08/21, 23:57 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2128
-
Benni Mack uploaded patch set 2 04/08/21, 23:58
-
TYPO3com voted on patch set 2 V +1 04/09/21, 00:05 Completed build in 07m 17s on Fri, 9 Apr, 12:05 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10568
-
core-ci voted on patch set 2 V +1 04/09/21, 00:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2129
-
Benni Mack uploaded patch set 3 04/09/21, 14:37
-
TYPO3com commented on patch set 3 04/09/21, 14:43 Completed build in 06m 21s on Fri, 9 Apr, 02:43 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10576
-
core-ci commented on patch set 3 04/09/21, 14:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2142
-
Oliver Hader commented on patch set 3 04/09/21, 20:19
PageTreeElement.ts:253`'typo3-backend-navigation-component-pagetree-toolbar'`? -
Benni Mack uploaded patch set 4 04/09/21, 20:31
-
Benni Mack commented on patch set 4 04/09/21, 20:31
PageTreeElement.ts:42Replythanks. you are right!PageTreeElement.ts:253ReplyDone -
TYPO3com voted on patch set 4 V +1 04/09/21, 20:37 Completed build in 06m 34s on Fri, 9 Apr, 08:37 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10586
-
Oliver Hader voted on patch set 4 CR +1 04/09/21, 20:40
-
core-ci voted on patch set 4 V +1 04/09/21, 20:43 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2153
-
Oliver Hader voted on patch set 4 V +1 04/09/21, 20:47
-
Oli Bartsch voted on patch set 4 V +1 CR +1 04/09/21, 20:52
-
Benni Mack voted on patch set 4 V +2 CR +2 04/09/21, 20:53
-
Benni Mack merged patch set 5 04/09/21, 20:53
PageTreeElement.ts:42