Review main Merged

68752[TASK] Unify SVG toolbar generation

Benni Mack CR +2 V +2 Normal +97 −141 updated 04/09/21, 20:53

Commit message

This change creates a default toolbar for SVG trees to filter, in order
to avoid duplicate code (which will be added via the SVG based trees
in the next feature again).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 8

Review log 1119

  1. Benni Mack uploaded patch set 1 04/08/21, 23:46

  2. TYPO3com voted on patch set 1 V +1 04/08/21, 23:53 Completed build in 06m 45s on Thu, 8 Apr, 11:53 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10567

  3. core-ci voted on patch set 1 V +1 04/08/21, 23:57 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2128

  4. Benni Mack uploaded patch set 2 04/08/21, 23:58

  5. TYPO3com voted on patch set 2 V +1 04/09/21, 00:05 Completed build in 07m 17s on Fri, 9 Apr, 12:05 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10568

  6. core-ci voted on patch set 2 V +1 04/09/21, 00:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2129

  7. Benni Mack uploaded patch set 3 04/09/21, 14:37

  8. TYPO3com commented on patch set 3 04/09/21, 14:43 Completed build in 06m 21s on Fri, 9 Apr, 02:43 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10576

  9. core-ci commented on patch set 3 04/09/21, 14:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2142

  10. Oliver Hader commented on patch set 3 04/09/21, 20:19

    PageTreeElement.ts:42

    Can this constant be removed as well? `<typo3-backend-navigation-component-pagetree-toolbar>` is hard-coded anyway in the template

    PageTreeElement.ts:253

    `'typo3-backend-navigation-component-pagetree-toolbar'`?
  11. Benni Mack uploaded patch set 4 04/09/21, 20:31

  12. Benni Mack commented on patch set 4 04/09/21, 20:31

    PageTreeElement.ts:42 Reply

    thanks. you are right!

    PageTreeElement.ts:253 Reply

    Done
  13. TYPO3com voted on patch set 4 V +1 04/09/21, 20:37 Completed build in 06m 34s on Fri, 9 Apr, 08:37 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10586

  14. Oliver Hader voted on patch set 4 CR +1 04/09/21, 20:40

  15. core-ci voted on patch set 4 V +1 04/09/21, 20:43 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2153

  16. Oliver Hader voted on patch set 4 V +1 04/09/21, 20:47

  17. Oli Bartsch voted on patch set 4 V +1 CR +1 04/09/21, 20:52

  18. Benni Mack voted on patch set 4 V +2 CR +2 04/09/21, 20:53

  19. Benni Mack merged patch set 5 04/09/21, 20:53