Review main Merged

68753[TASK] Re-style record list search box

Benni Mack CR +2 V +2 Hard +178 −142 updated 04/09/21, 21:23

Commit message

The search box (accessible via the list module in docheader, and
also used inside the Record Selector) is now simplified by
having a main select field, and additional settings as dropdown
available, making the search box - especially in the record selector -
much more easier to understand and to use. In addition, the record
selector search now looks similar to the File Selector (FAL relations),
as the File Selector uses the same markup now as well.

The doc header in the list module does not jump anymore when
choosing the search box, as this is also now moved into the
main document area, as all other modules (belog etc) use it as well.

The search box component is also extracted from the
DatabaseRecordList class, making it easier to re-use.

As the page module does not have the search anymore,
and thus, would rely on EXT:recordlist to just show the
button, the button (and thus, the jumpyness) is removed
there.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 10

Review log 1121

  1. Benni Mack uploaded patch set 1 04/09/21, 11:09

  2. TYPO3com voted on patch set 1 V +1 04/09/21, 11:16 Completed build in 07m 18s on Fri, 9 Apr, 11:16 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10571

  3. core-ci voted on patch set 1 V -1 04/09/21, 11:20 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2136

  4. Benni Mack uploaded patch set 2 04/09/21, 13:21

  5. TYPO3com voted on patch set 2 V +1 04/09/21, 13:27 Completed build in 06m 33s on Fri, 9 Apr, 01:27 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10574

  6. core-ci voted on patch set 2 V +1 04/09/21, 13:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2140

  7. Benni Mack uploaded patch set 3 04/09/21, 17:50

  8. TYPO3com voted on patch set 3 V -1 04/09/21, 17:50 Completed build in 15s on Fri, 9 Apr, 05:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10583

  9. core-ci voted on patch set 3 V +1 04/09/21, 18:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2150

  10. Oli Bartsch commented on patch set 3 04/09/21, 18:51

    RecordListController.php:311

    Should we check if `$beforeOutput` is empty to prevent empty markup?

    RecordSearchBoxComponent.php:2

    Let's declare strict types here.
  11. Benni Mack uploaded patch set 4 04/09/21, 20:43

  12. Benni Mack uploaded patch set 5 04/09/21, 20:45

  13. TYPO3com voted on patch set 4 V +1 04/09/21, 20:51 Completed build in 07m 34s on Fri, 9 Apr, 08:51 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10588

  14. Benni Mack commented on patch set 5 04/09/21, 20:52

    RecordListController.php:311 Reply

    Done

    RecordSearchBoxComponent.php:2 Reply

    Done
  15. TYPO3com voted on patch set 5 V +1 04/09/21, 20:52 Completed build in 06m 58s on Fri, 9 Apr, 08:52 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10589

  16. core-ci voted on patch set 4 V +1 04/09/21, 20:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2155

  17. core-ci voted on patch set 5 V +1 04/09/21, 21:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2156

  18. Oli Bartsch voted on patch set 5 V +1 CR +1 04/09/21, 21:19

  19. Oliver Hader commented on patch set 5 V +1 CR +1 04/09/21, 21:21

    UI of new drop-down panel still can be improved (later). But it's definitively a good direction and finally starts with "filter components"...
  20. Benni Mack voted on patch set 5 V +2 CR +2 04/09/21, 21:23

  21. Benni Mack merged patch set 6 04/09/21, 21:23