68754[BUGFIX] Fix event handler invocation in language pack download
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Xavier Perseguers +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Xavier Perseguers +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1114
-
Benjamin Franzke uploaded patch set 1 04/09/21, 12:51
-
TYPO3com voted on patch set 1 V +1 04/09/21, 12:58 Completed build in 07m 14s on Fri, 9 Apr, 12:58 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10572
-
core-ci voted on patch set 1 V +1 04/09/21, 13:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2138
-
Xavier Perseguers commented on patch set 1 V -1 04/09/21, 13:09
This does not seem to work with the sample code I provided in the ticket, my event listener is just not called at all. -
Benjamin Franzke commented on patch set 1 04/09/21, 13:52
Reply
Ok, seems we god a lot of places that use GU:makeInstance(LanguagePackService::class) in installtool context, will need to check each of them, as they need to be loaded from the symfony container as well. Out of interest, did you test in installtool or via command line? -
Xavier Perseguers commented on patch set 1 04/09/21, 14:26
tested from the Maintenance / Install Tool, not command line. -
Benjamin Franzke uploaded patch set 2 08/31/21, 06:47
-
Benjamin Franzke commented on patch set 2 08/31/21, 06:47
Reply
Ok, thanks, now repaired for both, maintenance/install-tool and for CLI command. Tested with the code you offered in the issue. I hope you can test again, despite this late fixup? -
Benjamin Franzke wrote 08/31/21, 06:47
Removed reviewer TYPO3com. -
core-ci voted on patch set 2 V +1 08/31/21, 07:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15903
-
Oli Bartsch voted on patch set 2 V +1 CR +1 08/31/21, 10:38
-
Xavier Perseguers commented on patch set 2 V +1 CR +1 09/01/21, 12:41
Many thanks. Successfully tested in the context of a v10 install -
Benjamin Franzke voted on patch set 2 V +2 CR +2 09/16/21, 20:27
-
Benjamin Franzke merged patch set 3 09/16/21, 20:28