Review main Merged

68755[TASK] Cleanup setup module

Oli Bartsch CR +2 V +2 Easy +4 −19 updated 04/09/21, 19:55

Commit message

Some cleanup of the SetupModuleController:

Remove an unused function for adding Javascript,
because it has not been executed since at least 7.6
and there are other ways to add custom Javascript
nowadays. For example with an event, introduced
in #91132, or directly via PageRenderer.

Remove an unused parameter, which has been
forgotten in #93093.

Remove two superfluous typecasts.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Oli Bartsch uploaded patch set 1 04/09/21, 19:22

  2. TYPO3com voted on patch set 1 V +1 04/09/21, 19:29 Completed build in 07m 11s on Fri, 9 Apr, 07:29 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10585

  3. core-ci voted on patch set 1 V +1 04/09/21, 19:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2152

  4. Markus Klein voted on patch set 1 V +1 CR +1 04/09/21, 19:49

  5. Benni Mack voted on patch set 1 V +2 CR +2 04/09/21, 19:55

  6. Benni Mack merged patch set 2 04/09/21, 19:55