Review main Merged

68756[TASK] Replace FormEngine update request invocation

Andreas Kienast CR +2 V +2 Normal +143 −41 updated 11/16/21, 18:40

Commit message

This patchs adds a new LitElement that invokes the update request of
FormEngine if a field's value with such configuration changes. This
replaces the current approach of huge onchange/onclick attributes
rendered per affected field.

A further patch will cleanup the necessity of TBE_EDITOR.fieldChanged().

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Anja Leichsenring +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 10

Review log 814

  1. Andreas Kienast uploaded patch set 1 04/11/21, 14:34

  2. TYPO3com voted on patch set 1 V +1 04/11/21, 14:41 Completed build in 07m 20s on Sun, 11 Apr, 02:41 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10602

  3. Andreas Kienast uploaded patch set 2 04/11/21, 14:43

  4. Andreas Kienast uploaded patch set 3 04/11/21, 14:45

  5. core-ci voted on patch set 1 V +1 04/11/21, 14:47 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2175

  6. TYPO3com voted on patch set 2 V +1 04/11/21, 14:50 Completed build in 06m 39s on Sun, 11 Apr, 02:50 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10603

  7. TYPO3com voted on patch set 3 V +1 04/11/21, 14:52 Completed build in 07m 28s on Sun, 11 Apr, 02:52 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10604

  8. core-ci voted on patch set 2 V +1 04/11/21, 14:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2176

  9. core-ci voted on patch set 3 V +1 04/11/21, 14:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2177

  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 04/12/21, 16:33

  11. Richard Haeser voted on patch set 3 V +2 CR +2 04/12/21, 19:00

  12. Richard Haeser merged patch set 4 04/13/21, 13:47

  13. Oliver Hader voted on patch set 4 CR +1 11/16/21, 18:40

  14. Oliver Hader wrote 11/16/21, 18:40

    Topic set to inline-javascript