Review main Merged

68757[TASK] Get rid of TBE_EDITOR.fieldChanged

Andreas Kienast CR +2 V +2 Normal +57 −25 updated 04/27/21, 19:57

Commit message

TBE_EDITOR has some old code still managing FormEngine today, even with
substitutions available since at least TYPO3 v7. This patch replaces the
last occurrences of TBE_EDITOR.fieldChanged() and deprecates the method.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 912

  1. Andreas Kienast uploaded patch set 1 04/11/21, 15:28

  2. Andreas Kienast commented on patch set 1 CR -2 04/11/21, 15:29

  3. TYPO3com voted on patch set 1 V +1 04/11/21, 15:34 Completed build in 06m 19s on Sun, 11 Apr, 03:34 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10605

  4. core-ci voted on patch set 1 V +1 04/11/21, 15:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2178

  5. Andreas Kienast uploaded patch set 2 04/23/21, 11:46

  6. Andreas Kienast voted on patch set 2 CR 0 04/23/21, 11:46

  7. TYPO3com voted on patch set 2 V +1 04/23/21, 11:54 Completed build in 08m 40s on Fri, 23 Apr, 11:54 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10826

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 04/27/21, 19:24

  9. Anja Leichsenring voted on patch set 2 V +1 CR +1 04/27/21, 19:37

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 04/27/21, 19:54

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 04/27/21, 19:57

  12. Oli Bartsch merged patch set 3 04/27/21, 19:57