Review main Merged

68758[BUGFIX] Use correct action code to fetch workspace comments

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 04/12/21, 12:20

Commit message

With #89483 some constants to have named DataHandler actions were
introduced. Unfortunately, a location in Workspace was forgotten which
made it impossible to load comments from a changed record.

This patch updates the SELECT query to use the correct action number
again.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Xavier Perseguers +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 1

Review log 610

  1. Andreas Kienast uploaded patch set 1 04/11/21, 16:13

  2. Andreas Kienast uploaded patch set 2 04/11/21, 16:13

  3. TYPO3com voted on patch set 1 V -1 04/11/21, 16:19 Completed build in 06m 18s on Sun, 11 Apr, 04:19 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10606

  4. TYPO3com voted on patch set 2 V +1 04/11/21, 16:21 Completed build in 07m 07s on Sun, 11 Apr, 04:21 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10607

  5. core-ci voted on patch set 1 V -1 04/11/21, 16:24 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2179

  6. core-ci voted on patch set 2 V +1 04/11/21, 16:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2180

  7. Xavier Perseguers commented on patch set 2 CR +1 04/11/21, 17:54

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 04/12/21, 09:07

  9. Georg Ringer voted on patch set 2 V +2 CR +2 04/12/21, 12:20

  10. Georg Ringer merged patch set 3 04/12/21, 12:20