Review main Merged

68759[TASK] Remove obsolete compatibility method HttpUtility::idn_to_ascii()

Martin Kutschker CR +2 V +2 Easy +6 −37 updated 04/27/21, 17:19

Commit message

Since PHP 7.4 the core can use the Intl function directly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1114

  1. Martin Kutschker uploaded patch set 1 04/11/21, 18:37

  2. TYPO3com voted on patch set 1 V +1 04/11/21, 18:43 Completed build in 06m 25s on Sun, 11 Apr, 06:43 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10612

  3. core-ci voted on patch set 1 V +1 04/11/21, 18:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2185

  4. Benni Mack commented on patch set 1 V +1 CR +1 04/19/21, 18:21

    Works for me (last time, I had to re-add it because of some Mittwald hosting provider problems)
  5. Benni Mack commented on patch set 1 V 0 CR -1 04/19/21, 18:22

    Actually, if we deprecate the method, we need to add a RST, but since this method is internal, we can remove it completely now.
  6. Martin Kutschker uploaded patch set 2 04/23/21, 11:25

  7. TYPO3com voted on patch set 2 V +1 04/23/21, 11:33 Completed build in 07m 38s on Fri, 23 Apr, 11:33 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10825

  8. Oli Bartsch commented on patch set 2 04/23/21, 11:36

    HttpUtility.php:18

    Should we then also remove "symfony/polyfill-intl-idn", since this was AFAICS the only usage of this polyfill?
  9. Martin Kutschker commented on patch set 2 04/23/21, 12:07

    HttpUtility.php:18 Reply

    The polyfill is used in this file for an edge case. Normally it justs implements idn_to_ascii in the boostrap.php of composer autoload. This means if we remove the polyfill, we require the Intl extension to be loaded. Currently it is only "suggested".
  10. Oli Bartsch commented on patch set 2 04/23/21, 12:14

    HttpUtility.php:18 Reply

    Ah, you're right. Thanks!
  11. Benni Mack commented on patch set 2 V +1 CR +1 04/23/21, 19:58

    Thank you for the adaptions!
  12. Anja Leichsenring voted on patch set 2 V +1 CR +1 04/27/21, 16:48

  13. Christian Kuhn voted on patch set 2 V +2 CR +2 04/27/21, 17:19

  14. Christian Kuhn merged patch set 3 04/27/21, 17:19