68759[TASK] Remove obsolete compatibility method HttpUtility::idn_to_ascii()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Routing/Router.php+1 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −2
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+2 −3
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/HttpUtility.php3+0 −28
- typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php+1 −1
Review log 1114
-
Martin Kutschker uploaded patch set 1 04/11/21, 18:37
-
TYPO3com voted on patch set 1 V +1 04/11/21, 18:43 Completed build in 06m 25s on Sun, 11 Apr, 06:43 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10612
-
core-ci voted on patch set 1 V +1 04/11/21, 18:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2185
-
Benni Mack commented on patch set 1 V +1 CR +1 04/19/21, 18:21
Works for me (last time, I had to re-add it because of some Mittwald hosting provider problems) -
Benni Mack commented on patch set 1 V 0 CR -1 04/19/21, 18:22
Actually, if we deprecate the method, we need to add a RST, but since this method is internal, we can remove it completely now. -
Martin Kutschker uploaded patch set 2 04/23/21, 11:25
-
TYPO3com voted on patch set 2 V +1 04/23/21, 11:33 Completed build in 07m 38s on Fri, 23 Apr, 11:33 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10825
-
Oli Bartsch commented on patch set 2 04/23/21, 11:36
HttpUtility.php:18Should we then also remove "symfony/polyfill-intl-idn", since this was AFAICS the only usage of this polyfill? -
Martin Kutschker commented on patch set 2 04/23/21, 12:07
HttpUtility.php:18ReplyThe polyfill is used in this file for an edge case. Normally it justs implements idn_to_ascii in the boostrap.php of composer autoload. This means if we remove the polyfill, we require the Intl extension to be loaded. Currently it is only "suggested". -
Oli Bartsch commented on patch set 2 04/23/21, 12:14
HttpUtility.php:18ReplyAh, you're right. Thanks! -
Benni Mack commented on patch set 2 V +1 CR +1 04/23/21, 19:58
Thank you for the adaptions! -
Anja Leichsenring voted on patch set 2 V +1 CR +1 04/27/21, 16:48
-
Christian Kuhn voted on patch set 2 V +2 CR +2 04/27/21, 17:19
-
Christian Kuhn merged patch set 3 04/27/21, 17:19