Review main Merged

6876[BUGFIX] Make generated thumbnails browser-cachable

Dmitry Dulepov CR +2 V +2 Normal +34 −33 updated 06/03/13, 20:49

Commit message

Thumbnail generation code appends current timestamp in each
invocation of the thumbnail generation script. This is useless
because it prevents caching. Removing this timestamp will not
cause any issues with old vs new versions because the URL
includes an md5 checksum of the file size and file timestamp.
So when the file is updated, the md5 sum will change. The
patch also changes short md5 to full md5.

Additionally proper last-modified, expires and etag headers
are sent.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Oliver Klee +1
  • Verified V +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Tolleiv Nietsch +1

Files 5

Review log 46

Show 21 earlier messages
  1. Dmitry Dulepov commented on patch set 1 03/07/12, 07:27

    (1 inline comment)
  2. Ingo Renner commented on patch set 2 03/07/12, 07:27

    the patch looks good to me and I agree with the reasoning as explained in the commit message.
  3. Dmitry Dulepov commented on patch set 2 03/07/12, 07:27

    Restored Restored because Markus Klein wants to continue this work.
  4. Dmitry Dulepov commented on patch set 2 03/07/12, 07:27

    Abandoned Nobody cares about fixes here.
  5. Dmitry Dulepov commented on patch set 2 03/07/12, 07:27

    (2 inline comments) Posting replies to inline comments.
  6. Stefan Neufeind commented on patch set 2 3 comments 03/07/12, 07:27

    I would prefer that you didn't submit this not sure how that $url is used to be used (see inline). rest looks okay
  7. Markus Klein commented on patch set 2 03/07/12, 07:27

    (1 inline comment)
  8. Stefan Neufeind commented on patch set 3 03/07/12, 07:27

    (2 inline comments) apart from those (valid) nitpicks looks fine to at first reading
  9. Markus Klein commented on patch set 3 03/07/12, 07:27

    (3 inline comments)
  10. Markus Klein uploaded patch set 3 03/07/12, 07:27

  11. Markus Klein uploaded patch set 4 03/07/12, 07:27

  12. Markus Klein uploaded patch set 5 03/07/12, 07:27

  13. Oliver Klee commented on patch set 3 03/07/12, 07:27

    (3 inline comments)
  14. Oliver Klee commented on patch set 4 2 comments 03/07/12, 07:27

    Looks good to me, but someone else must approve Nice! Just two case-mismatch nits.
  15. Oliver Klee commented on patch set 5 03/07/12, 07:27

    Looks good to me, but someone else must approve
  16. Oliver Hader commented on patch set 2 2 comments 03/07/12, 07:27

    I would prefer that you didn't submit this Did not review all classes since Gerrit seems to have probs with my Safari... but did just some...
  17. Oliver Hader uploaded patch set 2 03/07/12, 07:27

  18. Oliver Hader commented on patch set 2 03/07/12, 07:27

    Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Georg Ringer <mail@ringerge.org>
  19. Georg Ringer commented on patch set 1 03/07/12, 07:27

    Looks good to me, but someone else must approve

    thumbs.php:154

    can you explain the naming scheme of $md5Pre47? what does the 47 mean?
  20. Philipp Gampe commented on patch set 5 03/07/12, 07:27

    (1 inline comment) In general looks good, but caching is still not possible (at least not in Chrome and Firefox, but I think all browser behave the same here). This is because there is neither a last modified, nor an expires header.

    thumbs.php:236

    We need an at least the last modified and best the expires header here to allow the browser to cache the image.
  21. Dmitry Dulepov uploaded patch set 7 03/07/12, 07:27

  1. Dmitry Dulepov commented on patch set 7 03/07/12, 07:27

    Now properly cached in Chrome. See the screenshot here: http://img825.imageshack.us/img825/1048/fromcache.png
  2. Stefan Neufeind commented on patch set 7 03/07/12, 07:27

    Looks good to me, but someone else must approve
  3. Markus Klein commented on patch set 7 03/07/12, 07:27

    (1 inline comment)
  4. Tolleiv Nietsch commented on patch set 8 03/07/12, 07:27

    Verified; Looks good to me, but someone else must approve
  5. Tolleiv Nietsch commented on patch set 8 03/07/12, 07:27

    Looks good to me, approved
  6. Stefan Neufeind commented on patch set 8 2 comments 03/07/12, 07:27

    Looks good to me, but someone else must approve general +1 to go as is. Just another thought regarding the MD5-check
  7. Stefan Neufeind commented on patch set 8 V 0 03/07/12, 07:27

    works as designed but please see inline-comment regarding the old MD5 (Do we really need it?) adjust Releases-line before commit
  8. Markus Klein uploaded patch set 8 03/07/12, 07:27

  9. Oliver Klee commented on patch set 7 03/07/12, 07:27

    Looks good to me, but someone else must approve
  10. Oliver Klee commented on patch set 8 03/07/12, 07:27

    Looks good to me, but someone else must approve
  11. Georg Ringer commented on patch set 7 03/07/12, 07:27

    Verified; Looks good to me, but someone else must approve
  12. Steffen Ritter commented on patch set 8 V 0 03/07/12, 07:27

    by team member; Looks good to me, approved
  13. Johannes Feustel commented on patch set 7 03/07/12, 07:27

    (1 inline comment)
  14. Philipp Gampe uploaded patch set 6 03/07/12, 07:27

  15. Philipp Gampe commented on patch set 6 03/07/12, 07:27

    Verified; Looks good to me, but someone else must approve I added a proper last modified header. This triggers caching or firefox at least. However this does not seem to work for Chrome. Best thing we can do is to understand and respond to the if-modified-since header. This should be another change request following up this one.
  16. Philipp Gampe commented on patch set 7 03/07/12, 07:27

    Verified; Looks good to me, but someone else must approve Nice improvement.
  17. Mr. Jenkins commented on patch set 1 03/07/12, 07:27

  18. Mr. Jenkins commented on patch set 2 03/07/12, 07:27

  19. Mr. Jenkins commented on patch set 3 03/07/12, 07:27

  20. Mr. Jenkins commented on patch set 4 03/07/12, 07:27

  21. Mr. Jenkins commented on patch set 5 03/07/12, 07:27

  22. Mr. Jenkins commented on patch set 6 03/07/12, 07:27

  23. Mr. Jenkins commented on patch set 7 03/07/12, 07:27

  24. Mr. Jenkins commented on patch set 8 03/07/12, 07:27

  25. Steffen Ritter merged patch set 8 03/07/12, 07:27