Review main Merged

68763[TASK] Streamline moduleName handling

Benjamin Franzke CR +2 V +2 Normal +52 −12 updated 04/12/21, 21:08

Commit message

* Avoid custom moduleName in EXT:form and add a new moduleClass
   property for the purpose of custom controller styling
 * Use correct module name in view module (removing the custom one)
 * Advertise data-module-name body attribute in installtool modules

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 14

Review log 610

  1. Benjamin Franzke uploaded patch set 1 04/12/21, 15:52

  2. TYPO3com voted on patch set 1 V -1 04/12/21, 15:57 Completed build in 04m 58s on Mon, 12 Apr, 03:57 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10617

  3. Benjamin Franzke uploaded patch set 2 04/12/21, 16:02

  4. core-ci voted on patch set 1 V -1 04/12/21, 16:03 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2194

  5. TYPO3com voted on patch set 2 V +1 04/12/21, 16:08 Completed build in 06m 09s on Mon, 12 Apr, 04:08 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10618

  6. core-ci voted on patch set 2 V +1 04/12/21, 16:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2195

  7. Anja Leichsenring voted on patch set 2 V +1 04/12/21, 16:50

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 04/12/21, 20:31

  9. Benni Mack voted on patch set 2 V +2 CR +2 04/12/21, 21:08

  10. Benni Mack merged patch set 3 04/12/21, 21:08