Review main Merged

68765[TASK] Unify authentication form styles

Oli Bartsch CR +2 V +2 Hard +235 −98 updated 04/13/21, 12:31

Commit message

Using backend extension configuration, it's possible
to customize the authentication forms, e.g. login and
password recovery.

Since MFA was added as another part of this process,
the corresponding authentication forms must also
respect the customized styling.

This is achieved by extracting the logic form
LoginController and adding it to a dedicated
class `AuthenticationStyleInformation`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 6

Review log 816

  1. Oli Bartsch uploaded patch set 1 04/12/21, 19:16

  2. TYPO3com voted on patch set 1 V -1 04/12/21, 19:16 Completed build in 10s on Mon, 12 Apr, 07:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10626

  3. Oli Bartsch uploaded patch set 2 04/12/21, 19:17

  4. core-ci voted on patch set 1 V -1 04/12/21, 19:17 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2204

  5. TYPO3com voted on patch set 2 V +1 04/12/21, 19:25 Completed build in 07m 16s on Mon, 12 Apr, 07:25 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10627

  6. core-ci voted on patch set 2 V +1 04/12/21, 19:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2205

  7. Oli Bartsch uploaded patch set 3 04/12/21, 22:13

  8. Oli Bartsch updated the commit message in patch set 4 04/12/21, 22:15

  9. TYPO3com voted on patch set 3 V +1 04/12/21, 22:21 Completed build in 08m 24s on Mon, 12 Apr, 10:21 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10634

  10. TYPO3com voted on patch set 4 V +1 04/12/21, 22:22 Completed build in 07m 27s on Mon, 12 Apr, 10:22 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10635

  11. core-ci voted on patch set 3 V +1 04/12/21, 22:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2212

  12. core-ci voted on patch set 4 V +1 04/12/21, 22:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2213

  13. Benni Mack voted on patch set 4 V +1 CR +1 04/13/21, 10:03

  14. Jochen Roth voted on patch set 4 V +1 CR +1 04/13/21, 12:02

  15. Benni Mack voted on patch set 4 V +2 CR +2 04/13/21, 12:31

  16. Benni Mack merged patch set 5 04/13/21, 12:31