Review main Merged

68766[BUGFIX] Fix MSSQL support with Doctrine DBAL

Benni Mack CR +2 V +2 Easy +1 −5 updated 04/12/21, 20:44

Commit message

When using older versions with Doctrine DBAL
and "pdo_sqlsrv" the "free()" method was already
occupied and failed with MSSQL.

Instead, we rely on the closeCursor() method
which is available in all versions of Doctrine 2.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Benni Mack uploaded patch set 1 04/12/21, 19:37

  2. TYPO3com voted on patch set 1 V +1 04/12/21, 19:43 Completed build in 06m 37s on Mon, 12 Apr, 07:43 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10628

  3. core-ci voted on patch set 1 V +1 04/12/21, 19:47 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2206

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/12/21, 20:44

  5. Benni Mack merged patch set 2 04/12/21, 20:44