Review main Merged

68769[BUGFIX] Set background of td/th in ".table-transparent" to transparent

Jochen Roth CR +2 V +2 Easy +6 −1 updated 04/20/21, 12:56

Commit message

This solves a display white text on white background for
the selected size in image cropping tool panel

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 1325

  1. Jochen Roth uploaded patch set 1 04/13/21, 09:12

  2. TYPO3com voted on patch set 1 V -1 04/13/21, 09:19 Completed build in 07m 02s on Tue, 13 Apr, 09:19 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10637

  3. core-ci voted on patch set 1 V -1 04/13/21, 09:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2220

  4. Jochen Roth updated the commit message in patch set 2 04/13/21, 09:23

  5. TYPO3com voted on patch set 2 V -1 04/13/21, 09:30 Completed build in 06m 12s on Tue, 13 Apr, 09:30 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10638

  6. core-ci voted on patch set 2 V -1 04/13/21, 09:35 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2221

  7. Jochen Roth uploaded patch set 3 04/13/21, 09:42

  8. TYPO3com voted on patch set 3 V +1 04/13/21, 09:48 Completed build in 06m 41s on Tue, 13 Apr, 09:48 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10639

  9. core-ci voted on patch set 3 V +1 04/13/21, 09:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2222

  10. Guido Schmechel commented on patch set 3 04/18/21, 16:59

    Can you please rebase?
  11. Oli Bartsch uploaded patch set 4 04/18/21, 22:34

  12. TYPO3com voted on patch set 4 V +1 04/18/21, 22:39 Completed build in 05m 31s on Sun, 18 Apr, 10:39 PM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10709

  13. Oli Bartsch commented on patch set 4 04/18/21, 22:40

    _element_table.scss:201

    Should we also add "th" to be consistent with the other styles (see below) which do always apply to both "th" and "td"?
  14. core-ci voted on patch set 4 V +1 04/18/21, 22:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2311

  15. Jochen Roth uploaded patch set 5 04/19/21, 08:51

  16. Jochen Roth commented on patch set 5 04/19/21, 09:00

    Reply

    Done :-)

    _element_table.scss:201 Reply

    Added "th". Thanks.
  17. TYPO3com voted on patch set 5 V +1 04/19/21, 09:00 Completed build in 08m 42s on Mon, 19 Apr, 09:00 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10718

  18. core-ci voted on patch set 5 V +1 04/19/21, 09:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2324

  19. Jochen Roth uploaded patch set 6 04/20/21, 10:56

  20. Jochen Roth commented on patch set 6 04/20/21, 11:02

    Just resolved a merge conflict
  21. TYPO3com voted on patch set 6 V +1 04/20/21, 11:04 Completed build in 07m 37s on Tue, 20 Apr, 11:04 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10754

  22. core-ci voted on patch set 6 V +1 04/20/21, 11:15 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2365

  23. Oli Bartsch voted on patch set 6 V +1 CR +1 04/20/21, 12:55

  24. Benni Mack voted on patch set 6 V +2 CR +2 04/20/21, 12:56

  25. Benni Mack merged patch set 7 04/20/21, 12:56