Review main Merged

6877[BUGFIX] ENABLE_INSTALL_TOOL does not respect fileCreateMask

Dmitry Dulepov CR +2 V +2 Easy +4 −1 updated 06/03/13, 20:49

Commit message

When this file is created by the Install tool, the fileCreateMask
is not respected. That does not allow to delete this file through
FTP or from SSH if the web server user and group is different
from logged in user.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Hader +2
    • Mario Rimann +1
    • Stefan Neufeind +1
  • Verified V +2
    • Georg Ringer +2
    • Oliver Hader +1

Issues 1

Files 1

Review log 16

  1. Mario Rimann commented on patch set 1 12/18/11, 07:16

    Looks good to me, but someone else must approve
  2. Mario Rimann commented on patch set 2 12/18/11, 07:16

    Looks good to me, but someone else must approve
  3. Stefan Neufeind commented on patch set 2 1 comment 12/18/11, 07:16

    Looks good to me, but someone else must approve
  4. Oliver Hader uploaded patch set 2 12/18/11, 07:16

  5. Oliver Hader commented on patch set 2 12/18/11, 07:16

    Verified; Looks good to me, approved Rebasing to master V:1, R:2 V:0, R:1 from Mario Rimann <typo3-coding@rimann.org> V:0, R:1 from Helmut Hummel <typo3@helmut-hummel.de> V:0, R:1 from Georg Ringer <mail@ringerge.org> V:1, R:2 from Steffen Ritter <info@rs-websystems.de>
  6. Helmut Hummel commented on patch set 1 12/18/11, 07:16

    Looks good to me, but someone else must approve
  7. Georg Ringer commented on patch set 1 12/18/11, 07:16

    Looks good to me, but someone else must approve
  8. Steffen Ritter commented on patch set 1 12/18/11, 07:16

    Verified; Looks good to me, approved no brainer - imho
  9. Philipp Gampe commented on patch set 2 12/18/11, 07:16

    (1 inline comment)

    BasicService.php:56

    in case of an error, this returns FALSE. Shouldn't this be the return value then? So result = touch(...) && t3lib_div::fixPermissions(...);
  10. Philipp Gampe commented on patch set 2 12/18/11, 07:16

    any reason not to merge this nobrainer?
  11. Philipp Gampe commented on patch set 2 12/18/11, 07:16

    (1 inline comment)
  12. Simon Schaufelberger commented on patch set 2 12/18/11, 07:16

    (1 inline comment)

    BasicService.php:56 Reply

    did you test that on windows?
  13. Mr. Jenkins commented on patch set 1 12/18/11, 07:16

  14. Mr. Jenkins commented on patch set 2 12/18/11, 07:16

  15. Georg Ringer commented on patch set 2 V 0 12/18/11, 07:16

    by team member; Looks good to me, approved
  16. Georg Ringer merged patch set 2 12/18/11, 07:16