6877[BUGFIX] ENABLE_INSTALL_TOOL does not respect fileCreateMask
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Oliver Hader +2
- Mario Rimann +1
- Stefan Neufeind +1
-
Verified V +2
- Georg Ringer +2
- Oliver Hader +1
Issues 1
Files 1
Review log 16
-
Mario Rimann commented on patch set 1 12/18/11, 07:16
Looks good to me, but someone else must approve -
Mario Rimann commented on patch set 2 12/18/11, 07:16
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 1 comment 12/18/11, 07:16
Looks good to me, but someone else must approve -
Oliver Hader uploaded patch set 2 12/18/11, 07:16
-
Oliver Hader commented on patch set 2 12/18/11, 07:16
Verified; Looks good to me, approved Rebasing to master V:1, R:2 V:0, R:1 from Mario Rimann <typo3-coding@rimann.org> V:0, R:1 from Helmut Hummel <typo3@helmut-hummel.de> V:0, R:1 from Georg Ringer <mail@ringerge.org> V:1, R:2 from Steffen Ritter <info@rs-websystems.de> -
Helmut Hummel commented on patch set 1 12/18/11, 07:16
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 1 12/18/11, 07:16
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 1 12/18/11, 07:16
Verified; Looks good to me, approved no brainer - imho -
Philipp Gampe commented on patch set 2 12/18/11, 07:16
(1 inline comment)BasicService.php:56in case of an error, this returns FALSE. Shouldn't this be the return value then? So result = touch(...) && t3lib_div::fixPermissions(...); -
Philipp Gampe commented on patch set 2 12/18/11, 07:16
any reason not to merge this nobrainer? -
Philipp Gampe commented on patch set 2 12/18/11, 07:16
(1 inline comment) -
Simon Schaufelberger commented on patch set 2 12/18/11, 07:16
(1 inline comment)BasicService.php:56Replydid you test that on windows? -
Mr. Jenkins commented on patch set 1 12/18/11, 07:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2482/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/18/11, 07:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2646/ : SUCCESS -
Georg Ringer commented on patch set 2 V 0 12/18/11, 07:16
by team member; Looks good to me, approved -
Georg Ringer merged patch set 2 12/18/11, 07:16