Review main Merged

68771[TASK] Improve multi-factor authentication view

Oli Bartsch CR +2 V +2 Easy +13 −5 updated 04/16/21, 11:59

Commit message

Following improvements are done:

* Reduce margin-top of the MFA provider title
* The bottom border of card-body is changed to
a top border of card-footer to prevent the border
from being shown without a card-footer
* A new class `card-mfa` is added to the outer card
container to allow individual styling of the MFA view

Additionally this also fixes the custom styling options,
as these were still applied to the `panel` class, which
was however replaced by `card` during the bootstrap 5
migration.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 714

  1. Oli Bartsch uploaded patch set 1 04/13/21, 11:38

  2. TYPO3com voted on patch set 1 V -1 04/13/21, 11:45 Completed build in 07m 17s on Tue, 13 Apr, 11:45 AM Test Summary: 32858 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10642

  3. core-ci voted on patch set 1 V +1 04/13/21, 11:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2225

  4. TYPO3com voted on patch set 1 V +1 04/13/21, 11:53 Completed build in 22m 17s on Tue, 13 Apr, 11:53 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10642

  5. Oli Bartsch uploaded patch set 2 04/13/21, 12:43

  6. TYPO3com voted on patch set 2 V +1 04/13/21, 12:50 Completed build in 06m 49s on Tue, 13 Apr, 12:50 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10646

  7. core-ci voted on patch set 2 V +1 04/13/21, 12:54 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2228

  8. Jochen Roth voted on patch set 2 V +1 CR +1 04/16/21, 07:45

  9. Oli Bartsch uploaded patch set 3 04/16/21, 11:40

  10. Jochen Roth voted on patch set 3 V +1 CR +1 04/16/21, 11:41

  11. TYPO3com voted on patch set 3 V +1 04/16/21, 11:48 Completed build in 08m 07s on Fri, 16 Apr, 11:48 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10690

  12. core-ci voted on patch set 3 V +1 04/16/21, 11:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2284

  13. Benni Mack voted on patch set 3 V +2 CR +2 04/16/21, 11:59

  14. Benni Mack merged patch set 4 04/16/21, 11:59