Review main Merged

68773[TASK] Move reset password logic into a separate class

Oli Bartsch CR +2 V +2 Hard +468 −129 updated 04/19/21, 18:14

Commit message

Since the reset password logic does not directly relate
on the login step, just as MFA, it's now extracted into
a dedicated class. This also allows to cover it with
functional tests.

Next to some code cleanup, the reset password views do
now properly respect the common query parameters, like
`loginProvider` or `redirect`. This helps to unify the
overall authentication process UX as the user does not
longer lose these parameters in some views, while they
are kept in others.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 8

Review log 1022

  1. Oli Bartsch uploaded patch set 1 04/13/21, 21:00

  2. TYPO3com voted on patch set 1 V +1 04/13/21, 21:09 Completed build in 08m 07s on Tue, 13 Apr, 09:09 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10653

  3. core-ci voted on patch set 1 V +1 04/13/21, 21:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2235

  4. Oli Bartsch uploaded patch set 2 04/14/21, 10:07

  5. TYPO3com voted on patch set 2 V +1 04/14/21, 10:14 Completed build in 06m 53s on Wed, 14 Apr, 10:14 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10658

  6. core-ci voted on patch set 2 V +1 04/14/21, 10:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2243

  7. Oli Bartsch uploaded patch set 3 04/14/21, 13:47

  8. Oli Bartsch updated the commit message in patch set 4 04/14/21, 13:50

  9. TYPO3com voted on patch set 3 V +1 04/14/21, 13:54 Completed build in 06m 24s on Wed, 14 Apr, 01:54 PM Test Summary: 33285 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10660

  10. TYPO3com voted on patch set 4 V +1 04/14/21, 13:57 Completed build in 07m 20s on Wed, 14 Apr, 01:57 PM Test Summary: 33285 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10661

  11. core-ci voted on patch set 3 V +1 04/14/21, 13:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2245

  12. core-ci voted on patch set 4 V +1 04/14/21, 14:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2246

  13. Jochen Roth voted on patch set 4 V +1 CR +1 04/16/21, 12:01

  14. Oli Bartsch uploaded patch set 5 04/19/21, 09:05

  15. TYPO3com voted on patch set 5 V -1 04/19/21, 09:11 Completed build in 05m 38s on Mon, 19 Apr, 09:11 AM Test Summary: 3 of 33527 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10719

  16. core-ci voted on patch set 5 V -1 04/19/21, 09:20 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2325

  17. Oli Bartsch uploaded patch set 6 04/19/21, 10:26

  18. TYPO3com voted on patch set 6 V +1 04/19/21, 10:32 Completed build in 06m 25s on Mon, 19 Apr, 10:32 AM Test Summary: 33291 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10722

  19. Jochen Roth voted on patch set 6 V +1 CR +1 04/19/21, 10:35

  20. core-ci voted on patch set 6 V +1 04/19/21, 10:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2328

  21. Benni Mack voted on patch set 6 V +2 CR +2 04/19/21, 18:14

  22. Benni Mack merged patch set 7 04/19/21, 18:14