Review main Merged

68775[BUGFIX] Check if site language is enabled before redirecting

Georg Ringer CR +2 V +2 Normal +83 −1 updated 04/19/21, 19:02

Commit message

Only if a site language is enabled, it should be taken into account for
redirecting.
To keep the interface valid, the 1st site language is returned if no
other site language is found.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 1220

  1. Georg Ringer uploaded patch set 1 04/14/21, 18:31

  2. Georg Ringer commented on patch set 1 04/14/21, 18:32

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 04/14/21, 18:38 Completed build in 07m 14s on Wed, 14 Apr, 06:38 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10665

  4. core-ci voted on patch set 1 V +1 04/14/21, 18:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2250

  5. Benni Mack commented on patch set 1 CR -1 04/19/21, 17:03

    If this is done in the Site at this point, and a default language is disabled, the backend (e.g. page module) will not show the default language anymore
  6. Benni Mack uploaded patch set 2 04/19/21, 17:15

  7. Oliver Hader commented on patch set 2 04/19/21, 17:16

    SiteBaseRedirectResolver.php:61

    invert
  8. Benni Mack uploaded patch set 3 04/19/21, 17:20

  9. TYPO3com voted on patch set 2 V -1 04/19/21, 17:20 Completed build in 05m 37s on Mon, 19 Apr, 05:20 PM Test Summary: 2 of 33511 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10731

  10. Benni Mack uploaded patch set 4 04/19/21, 17:23

  11. TYPO3com voted on patch set 3 V +1 04/19/21, 17:26 Completed build in 05m 38s on Mon, 19 Apr, 05:26 PM Test Summary: 33277 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10732

  12. core-ci voted on patch set 2 V -1 04/19/21, 17:30 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2339

  13. TYPO3com voted on patch set 4 V +1 04/19/21, 17:32 Completed build in 08m 41s on Mon, 19 Apr, 05:32 PM Test Summary: 33277 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10733

  14. core-ci voted on patch set 3 V +1 04/19/21, 17:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2340

  15. core-ci voted on patch set 4 V +1 04/19/21, 17:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2341

  16. Oliver Hader voted on patch set 4 CR +1 04/19/21, 18:24

  17. Oliver Hader voted on patch set 4 V +1 04/19/21, 18:25

  18. Benni Mack voted on patch set 4 V +2 CR +2 04/19/21, 19:02

  19. Benni Mack merged patch set 5 04/19/21, 19:02

  20. Benni Mack commented on patch set 5 04/19/21, 19:02

    SiteBaseRedirectResolver.php:61 Reply

    Ack