Review main Merged

68776[BUGFIX] Restore altIcons TSconfig option

Oli Bartsch CR +2 V +2 Normal +177 −4 updated 04/16/21, 12:38

Commit message

In #35891 a feature was introduced, which allowed to
override the icon of select items via Page TSconfig.

This feature however did more or less never see the LTS
release, since it was almost completely removed in #67006
again.

Only SelectMultipleSideBySide provided this feature until
https://review.typo3.org/c/Packages/TYPO3.CMS/+/50879/.

It's now restored, using the original configuration path.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 8

Review log 46

  1. Oli Bartsch uploaded patch set 1 04/14/21, 20:24

  2. TYPO3com voted on patch set 1 V +1 04/14/21, 20:32 Completed build in 07m 48s on Wed, 14 Apr, 08:32 PM Test Summary: 33271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10667

  3. core-ci voted on patch set 1 V +1 04/14/21, 20:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2252

  4. Jochen Roth voted on patch set 1 V +1 CR +1 04/16/21, 12:33

  5. Benni Mack voted on patch set 1 V +2 CR +2 04/16/21, 12:38

  6. Benni Mack merged patch set 2 04/16/21, 12:38