Review main Merged

68777[BUGFIX] Fix checkbox items in "Global Configuration" card

Oli Bartsch CR +2 V +2 Easy +14 −16 updated 04/16/21, 11:38

Commit message

Resolve duplicated `class` declaration which prevented
the element from being recognized by the JavaScript
endpoint.

Add missing `form-check-label-text` class for the checkbox
label text.

Remove invalid `p` tags from checkbox elements description.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Oli Bartsch uploaded patch set 1 04/15/21, 12:27

  2. TYPO3com voted on patch set 1 V +1 04/15/21, 12:34 Completed build in 07m 06s on Thu, 15 Apr, 12:34 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10669

  3. core-ci voted on patch set 1 V +1 04/15/21, 12:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2258

  4. Jochen Roth voted on patch set 1 V +1 CR +1 04/16/21, 08:24

  5. Benni Mack voted on patch set 1 V +2 CR +2 04/16/21, 11:38

  6. Benni Mack merged patch set 2 04/16/21, 11:38