68778[TASK] Introduce composer manifest checks
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Helmut Hummel +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 15
- Build/Sources/Sass/typo3/_element_table.scss+3 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ActionDispatcher.ts+2 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ActionDispatcher.js+1 −1
- typo3/sysext/core/Classes/Package/ComposerDeficitDetector.phpnew+92 −0
- typo3/sysext/core/Documentation/Changelog/10.4.x/Important-93931-ValidationOfExensionsComposerjsonFiles.rst2new+32 −0
- typo3/sysext/extensionmanager/Classes/Controller/AbstractModuleController.php+5 −0
- typo3/sysext/extensionmanager/Classes/Controller/ExtensionComposerStatusController.php4new+189 −0
- typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php1new+116 −0
- typo3/sysext/extensionmanager/Classes/Service/ComposerManifestProposalGenerator.php6new+111 −0
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+110 −0
- typo3/sysext/extensionmanager/Resources/Private/Templates/ExtensionComposerStatus/Detail.htmlnew+32 −0
- typo3/sysext/extensionmanager/Resources/Private/Templates/ExtensionComposerStatus/List.htmlnew+77 −0
- typo3/sysext/extensionmanager/ext_localconf.php2+4 −0
- typo3/sysext/extensionmanager/ext_tables.php+2 −1
Review log 76138
Show 57113 earlier messages
-
Jochen Roth uploaded patch set 1 04/15/21, 15:33
-
TYPO3com voted on patch set 1 V -1 04/15/21, 15:34 Completed build in 20s on Thu, 15 Apr, 03:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10673
-
core-ci voted on patch set 1 V -1 04/15/21, 15:34 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2262
-
Jochen Roth uploaded patch set 2 04/15/21, 15:39
-
TYPO3com voted on patch set 2 V -1 04/15/21, 15:39 Completed build in 17s on Thu, 15 Apr, 03:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10674
-
core-ci voted on patch set 2 V -1 04/15/21, 15:40 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2263
-
Jochen Roth uploaded patch set 3 04/15/21, 15:41
-
TYPO3com voted on patch set 3 V -1 04/15/21, 15:41 Completed build in 16s on Thu, 15 Apr, 03:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10675
-
core-ci voted on patch set 3 V -1 04/15/21, 15:42 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2264
-
Jochen Roth uploaded patch set 4 04/15/21, 16:01
-
TYPO3com voted on patch set 4 V -1 04/15/21, 16:09 Completed build in 07m 43s on Thu, 15 Apr, 04:09 PM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10676
-
core-ci voted on patch set 4 V -1 04/15/21, 16:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2265
-
Jochen Roth uploaded patch set 5 04/15/21, 16:23
-
TYPO3com voted on patch set 5 V +1 04/15/21, 16:29 Completed build in 06m 40s on Thu, 15 Apr, 04:29 PM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10677
-
core-ci voted on patch set 5 V +1 04/15/21, 16:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2266
-
Benni Mack updated the commit message in patch set 6 04/16/21, 09:02
-
Benni Mack updated the commit message in patch set 7 04/16/21, 09:07
-
TYPO3com voted on patch set 6 V +1 04/16/21, 09:07 Completed build in 05m 14s on Fri, 16 Apr, 09:07 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10683
-
TYPO3com voted on patch set 7 V +1 04/16/21, 09:13 Completed build in 06m 06s on Fri, 16 Apr, 09:13 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10684
-
core-ci voted on patch set 6 V +1 04/16/21, 09:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2279
-
Benni Mack uploaded patch set 8 04/16/21, 09:15
-
core-ci voted on patch set 7 V +1 04/16/21, 09:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2280
-
TYPO3com voted on patch set 8 V +1 04/16/21, 09:21 Completed build in 05m 30s on Fri, 16 Apr, 09:21 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10685
-
core-ci voted on patch set 8 V +1 04/16/21, 09:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2281
-
Helmut Hummel commented on patch set 8 CR -1 04/16/21, 09:48
Thanks for moving forward in this area. I have some comments on the implementation though.ComposerController.php:56Potential information disclosure of full server pathComposerController.php:72since the extension key isn't validated and is passed in as request argument, path traversal will be possible here. likely, with passing in null bytes, any json file could be disclosed as well. I would suggest to check the extension key against an allow list of available active extensions.ComposerManifestForExtensionsStatus.php:50why is this public?ComposerManifestForExtensionsStatus.php:58my suggestion would be to use $extensionFolderComposerManifestForExtensionsStatus.php:60I find this additional finder overly complex. I'd rather do a string concatenation with file exists call insteadComposerManifestForExtensionsStatus.php:61not sure out of the top of my head. getFilename() is not an absolute path, but in this case the name of the extension folder, aka the ext key?ComposerManifestForExtensionsStatus.php:78this coud be moved directy to the place where $extensionKey is set and $extensionKey would be obsolete thenComposerManifestForExtensionsStatus.php:96I'd go for $type => $extensions, otherwise I find this confusing -
Jochen Roth uploaded patch set 9 04/16/21, 16:49
-
TYPO3com voted on patch set 9 V -1 04/16/21, 16:55 Completed build in 06m 29s on Fri, 16 Apr, 04:55 PM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10696
-
core-ci voted on patch set 9 V -1 04/16/21, 16:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2292
-
Jochen Roth uploaded patch set 10 04/19/21, 07:43
-
TYPO3com voted on patch set 10 V +1 04/19/21, 07:50 Completed build in 07m 13s on Mon, 19 Apr, 07:50 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10714
-
core-ci voted on patch set 10 V +1 04/19/21, 07:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2319
-
Jochen Roth commented on patch set 10 04/19/21, 08:01
Thanks for your review. Changed the code according to your suggestions.ComposerController.php:56Reply UnresolvedReturning only the path after doc-root now e.g. typoconf/EXT_KEY/composer.jsonComposerController.php:72Reply UnresolvedNow validating the extensions against the list of available extensions needing update. Hope thats ok too.ComposerManifestForExtensionsStatus.php:50Reply UnresolvedBy mistake. But now using it in ComposerController.php:54 for extension key validation.ComposerManifestForExtensionsStatus.php:58ReplyDoneComposerManifestForExtensionsStatus.php:60ReplyAckComposerManifestForExtensionsStatus.php:61Reply UnresolvedYes it is. Changed the name to $extensionKey.ComposerManifestForExtensionsStatus.php:78ReplyDoneComposerManifestForExtensionsStatus.php:96ReplyAck -
Benni Mack commented on patch set 10 04/19/21, 09:45
ComposerController.php:39TODO can be removed.ComposerController.php:40probably protected CONST?ComposerController.php:64I guess this would be typo3conf/ext/$extensionKey?ComposerController.php:81Unresolvedreturn type: stringComposerController.php:84just by reading... "double //"ComposerController.php:93there is a ClientFactory in place for this. -
Jochen Roth uploaded patch set 11 04/20/21, 09:42
-
TYPO3com voted on patch set 11 V +1 04/20/21, 09:48 Completed build in 06m 00s on Tue, 20 Apr, 09:48 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10752
-
Jochen Roth commented on patch set 11 04/20/21, 09:53
Applied your suggestions.ComposerController.php:39ReplyDoneComposerController.php:40ReplyDoneComposerController.php:64ReplyYes, fixed itComposerController.php:84Reply UnresolvedDouble checked, thats fine. Only "single /"ComposerController.php:93Reply UnresolvedNow using RequestFactory -
core-ci voted on patch set 11 V +1 04/20/21, 09:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2363
-
Benni Mack commented on patch set 11 CR -1 04/20/21, 13:17
on it -
Benni Mack uploaded patch set 12 04/20/21, 14:10
-
TYPO3com voted on patch set 12 V +1 04/20/21, 14:19 Completed build in 08m 36s on Tue, 20 Apr, 02:19 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10761
-
core-ci voted on patch set 12 V +1 04/20/21, 14:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2372
-
Jochen Roth uploaded patch set 13 04/20/21, 15:14
-
Jochen Roth uploaded patch set 14 04/20/21, 15:17
-
Jochen Roth commented on patch set 14 V +1 CR +1 04/20/21, 15:20
Updated label id and resname (resname and id now match) -
TYPO3com voted on patch set 13 V +1 04/20/21, 15:21 Completed build in 07m 19s on Tue, 20 Apr, 03:21 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10764
-
TYPO3com voted on patch set 14 V +1 04/20/21, 15:24 Completed build in 06m 12s on Tue, 20 Apr, 03:24 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10765
-
Benni Mack commented on patch set 14 CR -1 04/20/21, 15:27
Maybe we can make this a bit more prominent: * The Report should only show the number of extensions "There are 5 extensions... click for more details" The link should be underlined or sth like that. * The link does not necessarily need to open in a Modal box, we could just use a custom route / view (instead of AJAX view) that is connected in the dropdown of the Reports OR even the Extension Manager as a separate topic to actually list all extensions with details, and a custom click to show the composer.json. -
core-ci voted on patch set 13 V +1 04/20/21, 15:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2375
-
core-ci voted on patch set 14 V +1 04/20/21, 15:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2376
-
Oli Bartsch uploaded patch set 15 04/21/21, 14:13
-
TYPO3com voted on patch set 15 V +1 04/21/21, 14:20 Completed build in 06m 03s on Wed, 21 Apr, 02:20 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10780
-
core-ci voted on patch set 15 V +1 04/21/21, 14:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2394
-
Oli Bartsch uploaded patch set 16 04/21/21, 23:07
-
Oli Bartsch uploaded patch set 17 04/21/21, 23:09
-
TYPO3com voted on patch set 16 V +1 04/21/21, 23:15 Completed build in 08m 00s on Wed, 21 Apr, 11:15 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10788
-
TYPO3com voted on patch set 17 V +1 04/21/21, 23:17 Completed build in 07m 55s on Wed, 21 Apr, 11:17 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10789
-
core-ci voted on patch set 16 V +1 04/21/21, 23:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10585
-
core-ci voted on patch set 17 V +1 04/21/21, 23:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10586
-
Jochen Roth commented on patch set 17 04/22/21, 07:23
ext_localconf.php:23To have a proper headline for the module i would suggest to change ['composerManifest'][] to ['Composer Manifest'][] -
Oli Bartsch uploaded patch set 18 04/22/21, 11:26
-
Oli Bartsch commented on patch set 18 04/22/21, 11:27
ext_localconf.php:23ReplyDone -
TYPO3com voted on patch set 18 V +1 04/22/21, 11:32 Completed build in 06m 12s on Thu, 22 Apr, 11:32 AM Test Summary: 33306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10797
-
core-ci voted on patch set 18 V +1 04/22/21, 11:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10594
-
Oli Bartsch uploaded patch set 19 04/22/21, 12:34
-
Oli Bartsch commented on patch set 19 04/22/21, 12:34
This patch is ready for review. -
TYPO3com voted on patch set 19 V +1 04/22/21, 12:40 Completed build in 06m 13s on Thu, 22 Apr, 12:40 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10800
-
Benni Mack commented on patch set 19 04/22/21, 12:45
ComposerManifestProposalGenerator.php:68should we use DI here? same for the RequestFactory below. -
core-ci voted on patch set 19 V +1 04/22/21, 12:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10597
-
Oli Bartsch uploaded patch set 20 04/22/21, 12:54
-
Oli Bartsch commented on patch set 20 04/22/21, 12:54
ComposerManifestProposalGenerator.php:68ReplyDone -
TYPO3com voted on patch set 20 V +1 04/22/21, 13:01 Completed build in 07m 15s on Thu, 22 Apr, 01:01 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10803
-
core-ci voted on patch set 20 V +1 04/22/21, 13:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10600
-
Oli Bartsch commented on patch set 20 CR -1 04/22/21, 16:34
On it -
Oli Bartsch uploaded patch set 21 04/22/21, 21:07
-
TYPO3com voted on patch set 21 V -1 04/22/21, 21:15 Completed build in 07m 20s on Thu, 22 Apr, 09:15 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10816
-
core-ci voted on patch set 21 V -1 04/22/21, 21:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10618
-
Oli Bartsch uploaded patch set 22 04/22/21, 21:32
-
TYPO3com voted on patch set 22 V +1 04/22/21, 21:41 Completed build in 08m 35s on Thu, 22 Apr, 09:40 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10818
-
core-ci voted on patch set 22 V +1 04/22/21, 21:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10620
-
Jochen Roth voted on patch set 22 V +1 CR +1 04/23/21, 13:09
-
Oli Bartsch uploaded patch set 23 04/23/21, 13:38
-
TYPO3com voted on patch set 23 V +1 04/23/21, 13:44 Completed build in 06m 45s on Fri, 23 Apr, 01:44 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10834
-
Jochen Roth voted on patch set 23 V +1 CR +1 04/23/21, 14:13
-
Oli Bartsch rebased onto patch set 24 04/23/21, 14:31
-
TYPO3com voted on patch set 24 V +1 04/23/21, 14:40 Completed build in 08m 50s on Fri, 23 Apr, 02:40 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10839
-
core-ci voted on patch set 24 V +1 04/23/21, 14:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10656
-
Torben Hansen commented on patch set 24 04/24/21, 18:02
ExtensionComposerStatusController.php:164Should be registerDocHeaderButtons(). I know we have a mix of "Docheader" and "DocHeader" notations in the core, but I would prefer the latter as it simply is better to read/understand. -
Oli Bartsch uploaded patch set 25 04/24/21, 19:24
-
Oli Bartsch commented on patch set 25 04/24/21, 19:24
ExtensionComposerStatusController.php:164ReplyDone -
TYPO3com voted on patch set 25 V +1 04/24/21, 19:30 Completed build in 06m 10s on Sat, 24 Apr, 07:30 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10855
-
core-ci voted on patch set 25 V +1 04/24/21, 19:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10679
-
Helmut Hummel commented on patch set 25 04/26/21, 08:14
loComposerManifestProposalGenerator.php:56$extensionKey is still passed unfiltered and invalidated to a filesystem function here -
Helmut Hummel commented on patch set 25 CR -1 04/26/21, 09:33
ExtensionComposerStatusController.php:81we should not allow arbitrary values for returnUrl here, but pass it through GeneralUtility::sanitizeLocalUrl() -
Oli Bartsch uploaded patch set 26 04/26/21, 15:43
-
Oli Bartsch commented on patch set 26 04/26/21, 15:46
ExtensionComposerStatusController.php:81ReplyDoneComposerManifestProposalGenerator.php:56ReplyWe now apply a custom RegEx (including ".") and further validate with GeneralUtility::isAllowedAbsPath(). -
TYPO3com voted on patch set 26 V -1 04/26/21, 15:49 Completed build in 05m 40s on Mon, 26 Apr, 03:49 PM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10865
-
core-ci voted on patch set 26 V -1 04/26/21, 15:55 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10706
-
Oli Bartsch uploaded patch set 27 04/26/21, 16:04
-
Oli Bartsch uploaded patch set 28 04/26/21, 16:06
-
core-ci voted on patch set 27 V -1 04/26/21, 16:16 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10707
-
core-ci voted on patch set 28 V +1 04/26/21, 16:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10708
-
Oli Bartsch uploaded patch set 29 04/26/21, 16:53
-
core-ci voted on patch set 29 V +1 04/26/21, 17:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10709
-
Oli Bartsch uploaded patch set 30 04/26/21, 19:25
-
core-ci voted on patch set 30 V +1 04/26/21, 19:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10712
-
Oliver Hader commented on patch set 30 CR -1 04/27/21, 11:20
Going to have a look later and try to find a solution for those inline JavaScriptsExtensionComposerStatus.php:63UnresolvedHm... actually I'm trying to reduce the amount of inline JavaScript... -
Oliver Hader uploaded patch set 31 04/27/21, 19:59
-
Oliver Hader voted on patch set 31 V +1 CR +1 04/27/21, 20:01
-
core-ci voted on patch set 31 V +1 04/27/21, 20:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10780
-
Oli Bartsch voted on patch set 31 V +1 CR +1 04/27/21, 20:11
-
Oliver Hader voted on patch set 31 V +2 CR +2 04/27/21, 21:11
-
Oliver Hader voted on patch set 31 V 0 CR -1 04/27/21, 21:14
-
Benni Mack commented on patch set 31 04/27/21, 21:17
I think a Important.RST would be really good, to explain why we do this and in what direction we're moving.
-
Oliver Hader uploaded patch set 32 04/27/21, 21:19
-
Oliver Hader commented on patch set 32 04/27/21, 21:21
→ 10.4 back-port at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68895 -
core-ci voted on patch set 32 V +1 04/27/21, 21:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10796
-
Oli Bartsch commented on patch set 32 CR -1 04/27/21, 23:28
Need to check some detail. -
Benni Mack uploaded patch set 33 04/28/21, 15:15
-
core-ci voted on patch set 33 V +1 04/28/21, 15:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10841
-
Oli Bartsch uploaded patch set 34 04/28/21, 17:30
-
core-ci voted on patch set 34 V +1 04/28/21, 17:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10845
-
Oli Bartsch uploaded patch set 35 04/28/21, 17:47
-
core-ci voted on patch set 35 V +1 04/28/21, 17:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10846
-
Oli Bartsch uploaded patch set 36 04/28/21, 20:29
-
core-ci voted on patch set 36 V +1 04/28/21, 20:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10848
-
Benni Mack uploaded patch set 37 04/30/21, 20:18
-
core-ci voted on patch set 37 V +1 04/30/21, 20:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10987
-
Benni Mack voted on patch set 37 V +1 CR +1 04/30/21, 21:05
-
Oli Bartsch voted on patch set 37 V +1 CR +1 04/30/21, 22:50
-
Helmut Hummel commented on patch set 37 CR +1 05/01/21, 08:24
ComposerManifestProposalGenerator.php:56ReplyI can't find a way to exploit this any more. In general though, I'd rather have preferred a solution which checks against an allow list, rather having a deny list. E.g. using the package manager api to obtain a list of available extension keys and check against them. But seems good enough for now -
Benni Mack commented on patch set 37 05/01/21, 13:16
ComposerManifestProposalGenerator.php:56ReplyYeah, that was my idea (not using PackageManager) so it is not bound to just folders detected by PackageManager, and not fetching all packages through that API but be a bit less dependent on it. Instead, all folders are used (such as "news_bak") should be shown as well. shouldn't really make a huge difference in reality for existing installations. -
Oli Bartsch voted on patch set 37 V +2 CR +2 05/01/21, 13:26
-
Jochen Roth voted on patch set 37 V +1 CR +1 05/01/21, 13:26
-
Oli Bartsch merged patch set 38 05/01/21, 13:26
-
Xavier Perseguers commented on patch set 38 05/01/21, 15:59
wondering why this feature (silently changed as a task to be less prominent) was allowed to be backported to v10... -
Benni Mack commented on patch set 38 05/01/21, 16:11
Reply
It's that simple: People screamed at me for years to make TYPO3 Updates easier in the future, and this change helps people to prepare for future Core versions. -
Stephan Großberndt commented on patch set 38 05/01/21, 17:10
Important-93931-ValidationOfExensionsComposerjsonFiles.rst:4typo "exensions" here as well as in the file name -
Stephan Großberndt commented on patch set 38 05/04/21, 14:41
Important-93931-ValidationOfExensionsComposerjsonFiles.rst:4Reply