Review main Merged

68778[TASK] Introduce composer manifest checks

Jochen Roth CR +2 V +2 Hard +777 −3 updated 05/04/21, 14:41

Commit message

The extension manager now provides a new module,
which allows an integrator to display all available
extensions with composer deficits, like missing
composer.json or missing extension-key.

The new module informs about the deficit and
automatically generates a valid composer.json.
proposal. In case no composer.json exists, the
corresponding ext_emconf is sent to a new TER
endpoint (https://extensions.typo3.org/composerize).
This endpoint then generates a new composer.json
proposal by resolving all dependencies.

Furthermore, a new report is added to EXT:reports
which also informs about such extensions by directly
linking to the new EM module.

This helps especially in non-composer-mode installations
to ease the upgrade path for future TYPO3 versions which
(hopefully) will rely on composer.json only for e.g.
PackageStates.php.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Helmut Hummel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 76138

Show 57113 earlier messages
  1. Jochen Roth uploaded patch set 1 04/15/21, 15:33

  2. TYPO3com voted on patch set 1 V -1 04/15/21, 15:34 Completed build in 20s on Thu, 15 Apr, 03:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10673

  3. core-ci voted on patch set 1 V -1 04/15/21, 15:34 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2262

  4. Jochen Roth uploaded patch set 2 04/15/21, 15:39

  5. TYPO3com voted on patch set 2 V -1 04/15/21, 15:39 Completed build in 17s on Thu, 15 Apr, 03:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10674

  6. core-ci voted on patch set 2 V -1 04/15/21, 15:40 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2263

  7. Jochen Roth uploaded patch set 3 04/15/21, 15:41

  8. TYPO3com voted on patch set 3 V -1 04/15/21, 15:41 Completed build in 16s on Thu, 15 Apr, 03:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10675

  9. core-ci voted on patch set 3 V -1 04/15/21, 15:42 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2264

  10. Jochen Roth uploaded patch set 4 04/15/21, 16:01

  11. TYPO3com voted on patch set 4 V -1 04/15/21, 16:09 Completed build in 07m 43s on Thu, 15 Apr, 04:09 PM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10676

  12. core-ci voted on patch set 4 V -1 04/15/21, 16:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2265

  13. Jochen Roth uploaded patch set 5 04/15/21, 16:23

  14. TYPO3com voted on patch set 5 V +1 04/15/21, 16:29 Completed build in 06m 40s on Thu, 15 Apr, 04:29 PM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10677

  15. core-ci voted on patch set 5 V +1 04/15/21, 16:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2266

  16. Benni Mack updated the commit message in patch set 6 04/16/21, 09:02

  17. Benni Mack updated the commit message in patch set 7 04/16/21, 09:07

  18. TYPO3com voted on patch set 6 V +1 04/16/21, 09:07 Completed build in 05m 14s on Fri, 16 Apr, 09:07 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10683

  19. TYPO3com voted on patch set 7 V +1 04/16/21, 09:13 Completed build in 06m 06s on Fri, 16 Apr, 09:13 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10684

  20. core-ci voted on patch set 6 V +1 04/16/21, 09:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2279

  21. Benni Mack uploaded patch set 8 04/16/21, 09:15

  22. core-ci voted on patch set 7 V +1 04/16/21, 09:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2280

  23. TYPO3com voted on patch set 8 V +1 04/16/21, 09:21 Completed build in 05m 30s on Fri, 16 Apr, 09:21 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10685

  24. core-ci voted on patch set 8 V +1 04/16/21, 09:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2281

  25. Helmut Hummel commented on patch set 8 CR -1 04/16/21, 09:48

    Thanks for moving forward in this area. I have some comments on the implementation though.

    ComposerController.php:56

    Potential information disclosure of full server path

    ComposerController.php:72

    since the extension key isn't validated and is passed in as request argument, path traversal will be possible here. likely, with passing in null bytes, any json file could be disclosed as well. I would suggest to check the extension key against an allow list of available active extensions.

    ComposerManifestForExtensionsStatus.php:50

    why is this public?

    ComposerManifestForExtensionsStatus.php:58

    my suggestion would be to use $extensionFolder

    ComposerManifestForExtensionsStatus.php:60

    I find this additional finder overly complex. I'd rather do a string concatenation with file exists call instead

    ComposerManifestForExtensionsStatus.php:61

    not sure out of the top of my head. getFilename() is not an absolute path, but in this case the name of the extension folder, aka the ext key?

    ComposerManifestForExtensionsStatus.php:78

    this coud be moved directy to the place where $extensionKey is set and $extensionKey would be obsolete then

    ComposerManifestForExtensionsStatus.php:96

    I'd go for $type => $extensions, otherwise I find this confusing
  26. Jochen Roth uploaded patch set 9 04/16/21, 16:49

  27. TYPO3com voted on patch set 9 V -1 04/16/21, 16:55 Completed build in 06m 29s on Fri, 16 Apr, 04:55 PM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10696

  28. core-ci voted on patch set 9 V -1 04/16/21, 16:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2292

  29. Jochen Roth uploaded patch set 10 04/19/21, 07:43

  30. TYPO3com voted on patch set 10 V +1 04/19/21, 07:50 Completed build in 07m 13s on Mon, 19 Apr, 07:50 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10714

  31. core-ci voted on patch set 10 V +1 04/19/21, 07:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2319

  32. Jochen Roth commented on patch set 10 04/19/21, 08:01

    Thanks for your review. Changed the code according to your suggestions.

    ComposerController.php:56 Reply Unresolved

    Returning only the path after doc-root now e.g. typoconf/EXT_KEY/composer.json

    ComposerController.php:72 Reply Unresolved

    Now validating the extensions against the list of available extensions needing update. Hope thats ok too.

    ComposerManifestForExtensionsStatus.php:50 Reply Unresolved

    By mistake. But now using it in ComposerController.php:54 for extension key validation.

    ComposerManifestForExtensionsStatus.php:58 Reply

    Done

    ComposerManifestForExtensionsStatus.php:60 Reply

    Ack

    ComposerManifestForExtensionsStatus.php:61 Reply Unresolved

    Yes it is. Changed the name to $extensionKey.

    ComposerManifestForExtensionsStatus.php:78 Reply

    Done

    ComposerManifestForExtensionsStatus.php:96 Reply

    Ack
  33. Benni Mack commented on patch set 10 04/19/21, 09:45

    ComposerController.php:39

    TODO can be removed.

    ComposerController.php:40

    probably protected CONST?

    ComposerController.php:64

    I guess this would be typo3conf/ext/$extensionKey?

    ComposerController.php:81 Unresolved

    return type: string

    ComposerController.php:84

    just by reading... "double //"

    ComposerController.php:93

    there is a ClientFactory in place for this.
  34. Jochen Roth uploaded patch set 11 04/20/21, 09:42

  35. TYPO3com voted on patch set 11 V +1 04/20/21, 09:48 Completed build in 06m 00s on Tue, 20 Apr, 09:48 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10752

  36. Jochen Roth commented on patch set 11 04/20/21, 09:53

    Applied your suggestions.

    ComposerController.php:39 Reply

    Done

    ComposerController.php:40 Reply

    Done

    ComposerController.php:64 Reply

    Yes, fixed it

    ComposerController.php:84 Reply Unresolved

    Double checked, thats fine. Only "single /"

    ComposerController.php:93 Reply Unresolved

    Now using RequestFactory
  37. core-ci voted on patch set 11 V +1 04/20/21, 09:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2363

  38. Benni Mack commented on patch set 11 CR -1 04/20/21, 13:17

    on it
  39. Benni Mack uploaded patch set 12 04/20/21, 14:10

  40. TYPO3com voted on patch set 12 V +1 04/20/21, 14:19 Completed build in 08m 36s on Tue, 20 Apr, 02:19 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10761

  41. core-ci voted on patch set 12 V +1 04/20/21, 14:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2372

  42. Jochen Roth uploaded patch set 13 04/20/21, 15:14

  43. Jochen Roth uploaded patch set 14 04/20/21, 15:17

  44. Jochen Roth commented on patch set 14 V +1 CR +1 04/20/21, 15:20

    Updated label id and resname (resname and id now match)
  45. TYPO3com voted on patch set 13 V +1 04/20/21, 15:21 Completed build in 07m 19s on Tue, 20 Apr, 03:21 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10764

  46. TYPO3com voted on patch set 14 V +1 04/20/21, 15:24 Completed build in 06m 12s on Tue, 20 Apr, 03:24 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10765

  47. Benni Mack commented on patch set 14 CR -1 04/20/21, 15:27

    Maybe we can make this a bit more prominent: * The Report should only show the number of extensions "There are 5 extensions... click for more details" The link should be underlined or sth like that. * The link does not necessarily need to open in a Modal box, we could just use a custom route / view (instead of AJAX view) that is connected in the dropdown of the Reports OR even the Extension Manager as a separate topic to actually list all extensions with details, and a custom click to show the composer.json.
  48. core-ci voted on patch set 13 V +1 04/20/21, 15:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2375

  49. core-ci voted on patch set 14 V +1 04/20/21, 15:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2376

  50. Oli Bartsch uploaded patch set 15 04/21/21, 14:13

  51. TYPO3com voted on patch set 15 V +1 04/21/21, 14:20 Completed build in 06m 03s on Wed, 21 Apr, 02:20 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10780

  52. core-ci voted on patch set 15 V +1 04/21/21, 14:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2394

  53. Oli Bartsch uploaded patch set 16 04/21/21, 23:07

  54. Oli Bartsch uploaded patch set 17 04/21/21, 23:09

  55. TYPO3com voted on patch set 16 V +1 04/21/21, 23:15 Completed build in 08m 00s on Wed, 21 Apr, 11:15 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10788

  56. TYPO3com voted on patch set 17 V +1 04/21/21, 23:17 Completed build in 07m 55s on Wed, 21 Apr, 11:17 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10789

  57. core-ci voted on patch set 16 V +1 04/21/21, 23:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10585

  58. core-ci voted on patch set 17 V +1 04/21/21, 23:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10586

  59. Jochen Roth commented on patch set 17 04/22/21, 07:23

    ext_localconf.php:23

    To have a proper headline for the module i would suggest to change ['composerManifest'][] to ['Composer Manifest'][]
  60. Oli Bartsch uploaded patch set 18 04/22/21, 11:26

  61. Oli Bartsch commented on patch set 18 04/22/21, 11:27

    ext_localconf.php:23 Reply

    Done
  62. TYPO3com voted on patch set 18 V +1 04/22/21, 11:32 Completed build in 06m 12s on Thu, 22 Apr, 11:32 AM Test Summary: 33306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10797

  63. core-ci voted on patch set 18 V +1 04/22/21, 11:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10594

  64. Oli Bartsch uploaded patch set 19 04/22/21, 12:34

  65. Oli Bartsch commented on patch set 19 04/22/21, 12:34

    This patch is ready for review.
  66. TYPO3com voted on patch set 19 V +1 04/22/21, 12:40 Completed build in 06m 13s on Thu, 22 Apr, 12:40 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10800

  67. Benni Mack commented on patch set 19 04/22/21, 12:45

    ComposerManifestProposalGenerator.php:68

    should we use DI here? same for the RequestFactory below.
  68. core-ci voted on patch set 19 V +1 04/22/21, 12:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10597

  69. Oli Bartsch uploaded patch set 20 04/22/21, 12:54

  70. Oli Bartsch commented on patch set 20 04/22/21, 12:54

    ComposerManifestProposalGenerator.php:68 Reply

    Done
  71. TYPO3com voted on patch set 20 V +1 04/22/21, 13:01 Completed build in 07m 15s on Thu, 22 Apr, 01:01 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10803

  72. core-ci voted on patch set 20 V +1 04/22/21, 13:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10600

  73. Oli Bartsch commented on patch set 20 CR -1 04/22/21, 16:34

    On it
  74. Oli Bartsch uploaded patch set 21 04/22/21, 21:07

  75. TYPO3com voted on patch set 21 V -1 04/22/21, 21:15 Completed build in 07m 20s on Thu, 22 Apr, 09:15 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10816

  76. core-ci voted on patch set 21 V -1 04/22/21, 21:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10618

  77. Oli Bartsch uploaded patch set 22 04/22/21, 21:32

  78. TYPO3com voted on patch set 22 V +1 04/22/21, 21:41 Completed build in 08m 35s on Thu, 22 Apr, 09:40 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10818

  79. core-ci voted on patch set 22 V +1 04/22/21, 21:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10620

  80. Jochen Roth voted on patch set 22 V +1 CR +1 04/23/21, 13:09

  81. Oli Bartsch uploaded patch set 23 04/23/21, 13:38

  82. TYPO3com voted on patch set 23 V +1 04/23/21, 13:44 Completed build in 06m 45s on Fri, 23 Apr, 01:44 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10834

  83. Jochen Roth voted on patch set 23 V +1 CR +1 04/23/21, 14:13

  84. Oli Bartsch rebased onto patch set 24 04/23/21, 14:31

  85. TYPO3com voted on patch set 24 V +1 04/23/21, 14:40 Completed build in 08m 50s on Fri, 23 Apr, 02:40 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10839

  86. core-ci voted on patch set 24 V +1 04/23/21, 14:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10656

  87. Torben Hansen commented on patch set 24 04/24/21, 18:02

    ExtensionComposerStatusController.php:164

    Should be registerDocHeaderButtons(). I know we have a mix of "Docheader" and "DocHeader" notations in the core, but I would prefer the latter as it simply is better to read/understand.
  88. Oli Bartsch uploaded patch set 25 04/24/21, 19:24

  89. Oli Bartsch commented on patch set 25 04/24/21, 19:24

    ExtensionComposerStatusController.php:164 Reply

    Done
  90. TYPO3com voted on patch set 25 V +1 04/24/21, 19:30 Completed build in 06m 10s on Sat, 24 Apr, 07:30 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10855

  91. core-ci voted on patch set 25 V +1 04/24/21, 19:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10679

  92. Helmut Hummel commented on patch set 25 04/26/21, 08:14

    lo

    ComposerManifestProposalGenerator.php:56

    $extensionKey is still passed unfiltered and invalidated to a filesystem function here
  93. Helmut Hummel commented on patch set 25 CR -1 04/26/21, 09:33

    ExtensionComposerStatusController.php:81

    we should not allow arbitrary values for returnUrl here, but pass it through GeneralUtility::sanitizeLocalUrl()
  94. Oli Bartsch uploaded patch set 26 04/26/21, 15:43

  95. Oli Bartsch commented on patch set 26 04/26/21, 15:46

    ExtensionComposerStatusController.php:81 Reply

    Done

    ComposerManifestProposalGenerator.php:56 Reply

    We now apply a custom RegEx (including ".") and further validate with GeneralUtility::isAllowedAbsPath().
  96. TYPO3com voted on patch set 26 V -1 04/26/21, 15:49 Completed build in 05m 40s on Mon, 26 Apr, 03:49 PM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10865

  97. core-ci voted on patch set 26 V -1 04/26/21, 15:55 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10706

  98. Oli Bartsch uploaded patch set 27 04/26/21, 16:04

  99. Oli Bartsch uploaded patch set 28 04/26/21, 16:06

  100. core-ci voted on patch set 27 V -1 04/26/21, 16:16 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10707

  101. core-ci voted on patch set 28 V +1 04/26/21, 16:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10708

  102. Oli Bartsch uploaded patch set 29 04/26/21, 16:53

  103. core-ci voted on patch set 29 V +1 04/26/21, 17:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10709

  104. Oli Bartsch uploaded patch set 30 04/26/21, 19:25

  105. core-ci voted on patch set 30 V +1 04/26/21, 19:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10712

  106. Oliver Hader commented on patch set 30 CR -1 04/27/21, 11:20

    Going to have a look later and try to find a solution for those inline JavaScripts

    ExtensionComposerStatus.php:63 Unresolved

    Hm... actually I'm trying to reduce the amount of inline JavaScript...
  107. Oliver Hader uploaded patch set 31 04/27/21, 19:59

  108. Oliver Hader voted on patch set 31 V +1 CR +1 04/27/21, 20:01

  109. core-ci voted on patch set 31 V +1 04/27/21, 20:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10780

  110. Oli Bartsch voted on patch set 31 V +1 CR +1 04/27/21, 20:11

  111. Oliver Hader voted on patch set 31 V +2 CR +2 04/27/21, 21:11

  112. Oliver Hader voted on patch set 31 V 0 CR -1 04/27/21, 21:14

  113. Benni Mack commented on patch set 31 04/27/21, 21:17

    I think a Important.RST would be really good, to explain why we do this and in what direction we're moving.
  1. Oliver Hader uploaded patch set 32 04/27/21, 21:19

  2. Oliver Hader commented on patch set 32 04/27/21, 21:21

  3. core-ci voted on patch set 32 V +1 04/27/21, 21:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10796

  4. Oli Bartsch commented on patch set 32 CR -1 04/27/21, 23:28

    Need to check some detail.
  5. Benni Mack uploaded patch set 33 04/28/21, 15:15

  6. core-ci voted on patch set 33 V +1 04/28/21, 15:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10841

  7. Oli Bartsch uploaded patch set 34 04/28/21, 17:30

  8. core-ci voted on patch set 34 V +1 04/28/21, 17:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10845

  9. Oli Bartsch uploaded patch set 35 04/28/21, 17:47

  10. core-ci voted on patch set 35 V +1 04/28/21, 17:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10846

  11. Oli Bartsch uploaded patch set 36 04/28/21, 20:29

  12. core-ci voted on patch set 36 V +1 04/28/21, 20:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10848

  13. Benni Mack uploaded patch set 37 04/30/21, 20:18

  14. core-ci voted on patch set 37 V +1 04/30/21, 20:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10987

  15. Benni Mack voted on patch set 37 V +1 CR +1 04/30/21, 21:05

  16. Oli Bartsch voted on patch set 37 V +1 CR +1 04/30/21, 22:50

  17. Helmut Hummel commented on patch set 37 CR +1 05/01/21, 08:24

    ComposerManifestProposalGenerator.php:56 Reply

    I can't find a way to exploit this any more. In general though, I'd rather have preferred a solution which checks against an allow list, rather having a deny list. E.g. using the package manager api to obtain a list of available extension keys and check against them. But seems good enough for now
  18. Benni Mack commented on patch set 37 05/01/21, 13:16

    ComposerManifestProposalGenerator.php:56 Reply

    Yeah, that was my idea (not using PackageManager) so it is not bound to just folders detected by PackageManager, and not fetching all packages through that API but be a bit less dependent on it. Instead, all folders are used (such as "news_bak") should be shown as well. shouldn't really make a huge difference in reality for existing installations.
  19. Oli Bartsch voted on patch set 37 V +2 CR +2 05/01/21, 13:26

  20. Jochen Roth voted on patch set 37 V +1 CR +1 05/01/21, 13:26

  21. Oli Bartsch merged patch set 38 05/01/21, 13:26

  22. Xavier Perseguers commented on patch set 38 05/01/21, 15:59

    wondering why this feature (silently changed as a task to be less prominent) was allowed to be backported to v10...
  23. Benni Mack commented on patch set 38 05/01/21, 16:11

    Reply

    It's that simple: People screamed at me for years to make TYPO3 Updates easier in the future, and this change helps people to prepare for future Core versions.
  24. Stephan Großberndt commented on patch set 38 05/01/21, 17:10

    Important-93931-ValidationOfExensionsComposerjsonFiles.rst:4

    typo "exensions" here as well as in the file name
  25. Stephan Großberndt commented on patch set 38 05/04/21, 14:41