Review 9.5 Abandoned

68792[BUGFIX] Apply enableFields in JOIN's ON condition

Markus Klein CR 0 V 0 Normal +176 −18 updated 08/25/21, 19:50

Commit message

If an OUTER JOIN is requested, the "disabled" rows
of the joined table must be filtered before the join
is executed. Therefore the enableFields conditions
must be applied in the ON condition of the join.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1725

  1. Markus Klein uploaded patch set 1 04/16/21, 06:59

  2. TYPO3com voted on patch set 1 V -1 04/16/21, 07:00 Completed build in 24s on Fri, 16 Apr, 07:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1049

  3. core-ci voted on patch set 1 V -1 04/16/21, 07:01 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2272

  4. Markus Klein uploaded patch set 2 04/16/21, 07:02

  5. TYPO3com voted on patch set 2 V -1 04/16/21, 07:11 Completed build in 09m 18s on Fri, 16 Apr, 07:11 AM Test Summary: 12 of 76332 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1050

  6. core-ci voted on patch set 2 V -1 04/16/21, 07:15 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2273

  7. Markus Klein uploaded patch set 3 04/16/21, 07:50

  8. TYPO3com voted on patch set 3 V +1 04/16/21, 07:59 Completed build in 08m 51s on Fri, 16 Apr, 07:59 AM Test Summary: 75715 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1051

  9. core-ci voted on patch set 3 V +1 04/16/21, 08:04 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2274

  10. Markus Klein commented on patch set 3 V -1 05/18/21, 13:50

    https://forge.typo3.org/issues/94119 popped up for v10+. Extbase needs to be fixed.
  11. Markus Klein commented on patch set 3 05/18/21, 14:38

    Needs to be merged together with the backport of https://review.typo3.org/c/Packages/TYPO3.CMS/+/69177
  12. Markus Klein voted on patch set 3 V 0 05/20/21, 18:52

  13. Markus Klein commented on patch set 3 06/09/21, 19:49

    ready
  14. Christian Kuhn rebased onto patch set 4 06/09/21, 20:58

  15. core-ci voted on patch set 4 V +1 06/09/21, 21:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12245

  16. Oliver Klee commented on patch set 4 06/10/21, 16:06

    Connection.php:65

    Any particular reason for this field name being an abbreviation and having an underscore (which is not PSR-12-compatible)?
  17. Markus Klein commented on patch set 4 06/11/21, 06:29

    Connection.php:65 Reply

    Because it's defined in the parent class like this. We only redeclare in order to get correct types.
  18. Oliver Klee commented on patch set 4 06/11/21, 09:46

    Connection.php:65 Reply

    Ah, makes sense. Thanks for the explanation!
  19. Oliver Klee wrote 06/11/21, 09:46

    Removed reviewer Oliver Klee.
  20. Anja Leichsenring rebased onto patch set 5 08/09/21, 18:40

  21. core-ci voted on patch set 5 V +1 08/09/21, 18:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14399

  22. Stephan Großberndt commented on patch set 5 CR +1 08/25/21, 15:06

    I guess 9.5 is not getting that bugfix anymore?
  23. Christian Kuhn commented on patch set 5 08/25/21, 18:41

    Thx for bringing this up again, Stephan. After short chat with Markus: We'll not merge that patch in v9 anymore, to not risk a regression in late 9.5 life cycle. Instances that *really* need it, may be better off composer-patching this latest version, or patching an instance manually.
  24. Christian Kuhn abandoned the change 08/25/21, 18:41

  25. Stephan Großberndt commented on patch set 5 08/25/21, 19:50

    good decision 😊