Review 10.4 Merged

68793[BUGFIX] Prematurely end data array processing on invalid item

Oli Bartsch CR +2 V +2 Easy +21 −8 updated 04/16/21, 13:00

Commit message

In case the amount of items, shown in the workspace module,
does not exceed the pagination limit - default 30 - the items
array was previously filled with invalid items till the limit
was reached.

This is now fixed by a guard clause which prematurely ends the
processing (the corresponding loop) as soon as no more item
exists.

This guard clause is also implemented in the calculation of
the start value. Usually there shouldn't be any invalid items,
but as such behaviour can not always be ruled out, especially
on multi-user systems, it seems reasonable to add it here, too.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Oli Bartsch uploaded patch set 1 04/16/21, 08:53

  2. TYPO3com voted on patch set 1 V +1 04/16/21, 09:01 Completed build in 07m 23s on Fri, 16 Apr, 09:01 AM Test Summary: 75954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1313

  3. core-ci voted on patch set 1 V +1 04/16/21, 09:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2278

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/16/21, 13:00

  5. Benni Mack merged patch set 2 04/16/21, 13:00