Review main Merged

68794[BUGFIX] Add missing id to panel group element

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 04/16/21, 11:27

Commit message

The panel items in the global configuration card (EXT:install)
are referencing to a not defined `id` in their `data-bs-parent`
attribute.

This therefore lead to a JavaScript error within bootstrap
and is now fixed by adding the corresponding `id` to the
panel group element.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 04/16/21, 10:01

  2. TYPO3com voted on patch set 1 V +1 04/16/21, 10:07 Completed build in 05m 50s on Fri, 16 Apr, 10:07 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10686

  3. core-ci voted on patch set 1 V +1 04/16/21, 10:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2282

  4. Richard Haeser voted on patch set 1 V +1 CR +1 04/16/21, 11:18

  5. Jochen Roth voted on patch set 1 V +1 CR +1 04/16/21, 11:26

  6. Richard Haeser voted on patch set 1 V +2 CR +2 04/16/21, 11:27

  7. Richard Haeser merged patch set 2 04/16/21, 11:27