68795[BUGFIX] Fix reset password for backend user
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Jochen Roth +1
-
Verified V +2 Done
- Richard Haeser +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2433
Show 68 earlier messages
-
Jochen Roth uploaded patch set 1 04/16/21, 11:20
-
TYPO3com voted on patch set 1 V +1 04/16/21, 11:27 Completed build in 06m 45s on Fri, 16 Apr, 11:27 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10687
-
core-ci voted on patch set 1 V +1 04/16/21, 11:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2283
-
Richard Haeser commented on patch set 1 CR +1 04/16/21, 12:11
I don't get this warning as the default value is overruled by the user settings file_mountpoints which is not an array for me, but the change makes sense. -
Anja Leichsenring voted on patch set 1 V +1 CR +1 04/18/21, 06:41
-
Oliver Klee commented on patch set 1 04/18/21, 15:09
BackendUserAuthentication.php:78Should we change this to array<string> then to make this more clear? -
Jochen Roth commented on patch set 1 04/19/21, 09:03
BackendUserAuthentication.php:78ReplyThanks for reviewing. Does not seem necessary to me atm. -
Oli Bartsch commented on patch set 1 CR +1 04/19/21, 09:09
Reply
Same for me, I'm not able to reproduce this. However, code looks fine. So at least +1 for that.
-
Oliver Klee wrote 04/19/21, 10:24
Removed reviewer Oliver Klee. -
Benni Mack commented on patch set 1 04/19/21, 18:19
BackendUserAuthentication.php:78ReplyHmm, might be a good idea to do so @oliklee. But the groupData gets more data added in general which would then be mixed, right? By the way: can't we just remove the "filemounts" properties as we do not list all other properties either at this list as well? -
Jochen Roth uploaded patch set 2 04/20/21, 13:20
-
TYPO3com voted on patch set 2 V +1 04/20/21, 13:27 Completed build in 07m 24s on Tue, 20 Apr, 01:27 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10757
-
Jochen Roth uploaded patch set 3 04/20/21, 13:27
-
core-ci voted on patch set 2 V +1 04/20/21, 13:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2368
-
Jochen Roth commented on patch set 3 04/20/21, 13:33
BackendUserAuthentication.php:78Reply UnresolvedRemoved "filemounts" property which worked without issues. -
TYPO3com voted on patch set 3 V +1 04/20/21, 13:35 Completed build in 07m 13s on Tue, 20 Apr, 01:35 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10758
-
core-ci voted on patch set 3 V +1 04/20/21, 13:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2369
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 04/20/21, 17:46
-
Wouter Wolters voted on patch set 3 CR +1 04/20/21, 19:12
-
Benni Mack commented on patch set 3 04/21/21, 08:40
how can I test this? -
Jochen Roth commented on patch set 3 04/22/21, 07:48
Reply
Try to reset the password using the "Reset Password" button on login screen -
Benni Mack commented on patch set 3 04/22/21, 20:50
Reply
yes. this works for me even without the patch -
Oli Bartsch commented on patch set 3 04/23/21, 21:18
While I'm still not able to reproduce this, could you please improve the commit message by explaining what this patch does and more important: Why this fixes the bug. -
Jochen Roth uploaded patch set 4 04/25/21, 16:39
-
TYPO3com voted on patch set 4 V +1 04/25/21, 16:45 Completed build in 06m 06s on Sun, 25 Apr, 04:45 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10861
-
core-ci voted on patch set 4 V +1 04/25/21, 16:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10689
-
Jochen Roth abandoned the change 05/21/21, 14:41
Already fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012 -
Oli Bartsch restored the change 05/26/21, 10:06
-
Oli Bartsch uploaded patch set 5 05/26/21, 10:08
-
core-ci voted on patch set 5 V +1 05/26/21, 10:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11864
-
Jochen Roth voted on patch set 5 V +1 CR +1 05/26/21, 11:59
-
Richard Haeser voted on patch set 5 V +2 CR +2 05/26/21, 12:06
-
Richard Haeser merged patch set 6 05/26/21, 12:07