Review main Merged

68795[BUGFIX] Fix reset password for backend user

Jochen Roth CR +2 V +2 Easy +0 −1 updated 05/26/21, 12:07

Commit message

Remove groupData filemounts property because it causes
GeneralUtility::intExplode to crash when $this->groupData['filemounts']
is defined as a empty array.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2433

Show 68 earlier messages
  1. Jochen Roth uploaded patch set 1 04/16/21, 11:20

  2. TYPO3com voted on patch set 1 V +1 04/16/21, 11:27 Completed build in 06m 45s on Fri, 16 Apr, 11:27 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10687

  3. core-ci voted on patch set 1 V +1 04/16/21, 11:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2283

  4. Richard Haeser commented on patch set 1 CR +1 04/16/21, 12:11

    I don't get this warning as the default value is overruled by the user settings file_mountpoints which is not an array for me, but the change makes sense.
  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 04/18/21, 06:41

  6. Oliver Klee commented on patch set 1 04/18/21, 15:09

    BackendUserAuthentication.php:78

    Should we change this to array<string> then to make this more clear?
  7. Jochen Roth commented on patch set 1 04/19/21, 09:03

    BackendUserAuthentication.php:78 Reply

    Thanks for reviewing. Does not seem necessary to me atm.
  8. Oli Bartsch commented on patch set 1 CR +1 04/19/21, 09:09

    Reply

    Same for me, I'm not able to reproduce this. However, code looks fine. So at least +1 for that.
  1. Oliver Klee wrote 04/19/21, 10:24

    Removed reviewer Oliver Klee.
  2. Benni Mack commented on patch set 1 04/19/21, 18:19

    BackendUserAuthentication.php:78 Reply

    Hmm, might be a good idea to do so @oliklee. But the groupData gets more data added in general which would then be mixed, right? By the way: can't we just remove the "filemounts" properties as we do not list all other properties either at this list as well?
  3. Jochen Roth uploaded patch set 2 04/20/21, 13:20

  4. TYPO3com voted on patch set 2 V +1 04/20/21, 13:27 Completed build in 07m 24s on Tue, 20 Apr, 01:27 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10757

  5. Jochen Roth uploaded patch set 3 04/20/21, 13:27

  6. core-ci voted on patch set 2 V +1 04/20/21, 13:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2368

  7. Jochen Roth commented on patch set 3 04/20/21, 13:33

    BackendUserAuthentication.php:78 Reply Unresolved

    Removed "filemounts" property which worked without issues.
  8. TYPO3com voted on patch set 3 V +1 04/20/21, 13:35 Completed build in 07m 13s on Tue, 20 Apr, 01:35 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10758

  9. core-ci voted on patch set 3 V +1 04/20/21, 13:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2369

  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 04/20/21, 17:46

  11. Wouter Wolters voted on patch set 3 CR +1 04/20/21, 19:12

  12. Benni Mack commented on patch set 3 04/21/21, 08:40

    how can I test this?
  13. Jochen Roth commented on patch set 3 04/22/21, 07:48

    Reply

    Try to reset the password using the "Reset Password" button on login screen
  14. Benni Mack commented on patch set 3 04/22/21, 20:50

    Reply

    yes. this works for me even without the patch
  15. Oli Bartsch commented on patch set 3 04/23/21, 21:18

    While I'm still not able to reproduce this, could you please improve the commit message by explaining what this patch does and more important: Why this fixes the bug.
  16. Jochen Roth uploaded patch set 4 04/25/21, 16:39

  17. TYPO3com voted on patch set 4 V +1 04/25/21, 16:45 Completed build in 06m 06s on Sun, 25 Apr, 04:45 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10861

  18. core-ci voted on patch set 4 V +1 04/25/21, 16:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10689

  19. Jochen Roth abandoned the change 05/21/21, 14:41

  20. Oli Bartsch restored the change 05/26/21, 10:06

  21. Oli Bartsch uploaded patch set 5 05/26/21, 10:08

  22. core-ci voted on patch set 5 V +1 05/26/21, 10:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11864

  23. Jochen Roth voted on patch set 5 V +1 CR +1 05/26/21, 11:59

  24. Richard Haeser voted on patch set 5 V +2 CR +2 05/26/21, 12:06

  25. Richard Haeser merged patch set 6 05/26/21, 12:07