Review main Merged

68796[BUGFIX] Replace duplicated form attributes in LinkBrowser

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 04/19/21, 07:52

Commit message

The form to update an already existing link in the
LinkBrowser used the same name and id as the
form for "Additional Attributes". This now leads
to a JavaScript warning being emitted.

The issue is fixed by replacing the duplicated name
and id attribute.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 04/16/21, 12:22

  2. TYPO3com voted on patch set 1 V +1 04/16/21, 12:29 Completed build in 07m 00s on Fri, 16 Apr, 12:29 PM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10691

  3. Benni Mack voted on patch set 1 CR +1 04/16/21, 12:31

  4. core-ci voted on patch set 1 V +1 04/16/21, 12:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2285

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 04/18/21, 06:39

  6. Guido Schmechel voted on patch set 1 V +1 CR +1 04/18/21, 16:56

  7. Richard Haeser voted on patch set 1 V +2 CR +2 04/19/21, 07:52

  8. Richard Haeser merged patch set 2 04/19/21, 07:52