68797[TASK] Allow PSR-7 Request in User Authentication chain
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/Controller/AjaxLoginController.php+1 −1
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php8+12 −6
- typo3/sysext/core/Classes/Authentication/CommandLineUserAuthentication.php+5 −2
- typo3/sysext/core/Classes/Core/Bootstrap.php+4 −2
- typo3/sysext/core/Tests/Acceptance/Support/Extension/BackendCoreEnvironment.php2+45 −1
- typo3/sysext/frontend/Classes/Middleware/BackendUserAuthenticator.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+18 −12
- composer.json+1 −1
- composer.lock+8 −7
Review log 2335
Show 510 earlier messages
-
Benni Mack uploaded patch set 1 04/16/21, 12:59
-
TYPO3com voted on patch set 1 V -1 04/16/21, 13:03 Completed build in 04m 31s on Fri, 16 Apr, 01:03 PM Test Summary: 9847 of 33509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10694
-
core-ci voted on patch set 1 V -1 04/16/21, 13:13 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2291
-
Oliver Hader commented on patch set 1 04/16/21, 13:20
-
Benni Mack uploaded patch set 2 04/19/21, 11:10
-
TYPO3com voted on patch set 2 V -1 04/19/21, 11:16 Completed build in 05m 09s on Mon, 19 Apr, 11:16 AM Test Summary: 11123 of 33509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10723
-
core-ci voted on patch set 2 V -1 04/19/21, 11:30 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2331
-
Benni Mack rebased onto patch set 3 06/13/21, 15:30
-
core-ci voted on patch set 3 V -1 06/13/21, 15:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12378
-
Christian Kuhn rebased onto patch set 4 09/10/21, 15:43
-
core-ci voted on patch set 4 V -1 09/10/21, 16:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16501
-
Christian Kuhn commented on patch set 4 09/11/21, 09:11
AbstractUserAuthentication.php:257Replyimho $request should not be injected but carried around: Request is not a service but a DTO and should not be injectable. -
Christian Kuhn uploaded patch set 5 09/11/21, 09:35
-
core-ci voted on patch set 5 V -1 09/11/21, 09:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16525
-
Stefan Bürk commented on patch set 5 09/28/21, 09:09
AbstractUserAuthentication.php:260This fails acceptance tests. Reason is thet Bootstrap::initializeBackendUser() is called in acceptance CoreBootstrapEnvironment, which itself calls ->start() without a corresponding ServerRequest, and as there is no real request at this state, it failes. -
Stefan Bürk uploaded patch set 6 09/28/21, 09:10
-
Stefan Bürk commented on patch set 6 09/28/21, 09:11
AbstractUserAuthentication.php:260ReplyDone -
core-ci voted on patch set 6 V -1 09/28/21, 09:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17250
-
Stefan Bürk commented on patch set 6 09/28/21, 17:45
BackendCoreEnvironment.php:120As commented as ToDo - consider move to TF -> BackendEnvironment. Anyway is a code duplicate, but when it is in TF we can thing about a shared solution that later and not blocking that patch as this needs a new TF version anyway shortly (if PR is merged) -
Benni Mack uploaded patch set 7 10/01/21, 09:52
-
core-ci voted on patch set 7 V +1 10/01/21, 10:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17396
-
Benni Mack commented on patch set 7 10/01/21, 10:17
BackendCoreEnvironment.php:120ReplyI think we should keep this as duplicate for the time being (the Acceptance test had some other nasty issues around request handling), but we should adapt this in v12. -
Benni Mack updated the commit message in patch set 8 10/01/21, 10:28
-
core-ci voted on patch set 8 V +1 10/01/21, 10:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17402
-
Benni Mack uploaded patch set 9 10/01/21, 11:01
-
core-ci voted on patch set 9 V +1 10/01/21, 11:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17406
-
Stefan Bürk commented on patch set 9 V +1 CR +1 10/01/21, 12:25
Thx for the patch Benny. Tested (in beetween and) on last patchset. -
Christian Kuhn commented on patch set 9 CR -1 10/01/21, 12:40
AbstractUserAuthentication.php:258add a todo to make this non-optional in v12?AbstractUserAuthentication.php:430add a todo to make this non-optional in v12? -
Christian Kuhn uploaded patch set 10 10/01/21, 12:46
-
Christian Kuhn commented on patch set 10 V +1 CR +1 10/01/21, 12:47
AbstractUserAuthentication.php:258ReplyDoneAbstractUserAuthentication.php:430ReplyDone -
Stefan Bürk voted on patch set 10 V +1 CR +1 10/01/21, 12:47
-
core-ci voted on patch set 10 V +1 10/01/21, 13:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17425
-
Anja Leichsenring voted on patch set 10 V +1 CR +1 10/01/21, 13:02
-
Christian Kuhn voted on patch set 10 V +2 CR +2 10/01/21, 13:02
-
Christian Kuhn merged patch set 11 10/01/21, 13:02
AbstractUserAuthentication.php:257