Review main Merged

68799[TASK] Remove legacy tree implementations

Benni Mack CR +2 V +2 Expert +116 −1949 updated 04/20/21, 10:19

Commit message

Various PHP classes, which were previously a specific implementation
for various Link Picker / Element Browser renderings for trees
are removed.

In addition, the so-called "LegacyTree" is removed along with
all entry points, also for the "navFrameScript" of the iframe inside
the File main module.

Modules who previously registered to the iFrame navigation
component are now moved to the new file storage component.

Since the related code was marked as internal, the files are removed
without substitution.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 21

Show 1 more file

Review log 1424

  1. Benni Mack uploaded patch set 1 04/19/21, 07:59

  2. TYPO3com voted on patch set 1 V +1 04/19/21, 08:06 Completed build in 06m 48s on Mon, 19 Apr, 08:06 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10717

  3. core-ci voted on patch set 1 V +1 04/19/21, 08:13 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2322

  4. Oliver Hader commented on patch set 1 04/19/21, 10:03

    AbstractTreeView.php:517

    I guess this can be removed as well (since `jumpTo` was declared in `FileSystemNavigationController`). Same for `BrowserTreeView` (the call hierarchy looks weird, I have to check that in more detail)
  5. Benni Mack uploaded patch set 2 04/19/21, 10:07

  6. TYPO3com voted on patch set 2 V +1 04/19/21, 10:14 Completed build in 07m 35s on Mon, 19 Apr, 10:14 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10721

  7. core-ci voted on patch set 2 V +1 04/19/21, 10:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2327

  8. Jochen Roth voted on patch set 2 V +1 CR +1 04/19/21, 12:49

  9. Oliver Hader commented on patch set 2 CR -1 04/19/21, 13:23

    On it
  10. Oliver Hader uploaded patch set 3 04/19/21, 13:25

  11. Oliver Hader voted on patch set 3 V +1 CR +1 04/19/21, 13:26

  12. TYPO3com voted on patch set 3 V +1 04/19/21, 13:32 Completed build in 06m 54s on Mon, 19 Apr, 01:32 PM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10725

  13. core-ci voted on patch set 3 V +1 04/19/21, 13:36 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2333

  14. Benni Mack uploaded patch set 4 04/19/21, 13:46

  15. TYPO3com voted on patch set 4 V +1 04/19/21, 13:54 Completed build in 07m 37s on Mon, 19 Apr, 01:53 PM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10726

  16. core-ci voted on patch set 4 V +1 04/19/21, 13:56 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2334

  17. Oliver Hader uploaded patch set 5 04/19/21, 14:00

  18. TYPO3com voted on patch set 5 V +1 04/19/21, 14:06 Completed build in 05m 20s on Mon, 19 Apr, 02:06 PM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10727

  19. core-ci voted on patch set 5 V +1 04/19/21, 14:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2335

  20. Oliver Hader voted on patch set 5 V +1 CR +1 04/19/21, 14:25

  21. Benni Mack commented on patch set 5 04/20/21, 08:44

    AbstractTreeView.php:517 Reply

    Ack
  22. Christian Kuhn commented on patch set 5 CR -1 04/20/21, 09:22

    on it.
  23. Christian Kuhn commented on patch set 5 V +2 CR +2 04/20/21, 10:19

    quite hairy inheritance tree. this patch improves the situation a lot.
  24. Christian Kuhn merged patch set 6 04/20/21, 10:19