Review main Merged

68800[BUGFIX] Make context menu icon in SVG tree better clickable

Benni Mack CR +2 V +2 Easy +12 −2 updated 04/22/21, 05:42

Commit message

This change adds a <rect> element inside the icon group for
making the icon better clickable.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Ayke Halder +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 2

Review log 1424

  1. Benni Mack uploaded patch set 1 04/19/21, 09:41

  2. TYPO3com voted on patch set 1 V +1 04/19/21, 09:48 Completed build in 07m 13s on Mon, 19 Apr, 09:48 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10720

  3. core-ci voted on patch set 1 V +1 04/19/21, 09:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2326

  4. Jochen Roth voted on patch set 1 V +1 CR +1 04/19/21, 09:56

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 04/19/21, 10:01

  6. Benni Mack updated the commit message in patch set 2 04/19/21, 11:13

  7. Benni Mack commented on patch set 2 04/19/21, 11:13

    maybe we should use <rect> instead.
  8. TYPO3com voted on patch set 2 V +1 04/19/21, 11:20 Completed build in 07m 05s on Mon, 19 Apr, 11:20 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10724

  9. core-ci voted on patch set 2 V +1 04/19/21, 11:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2332

  10. Benni Mack uploaded patch set 3 04/20/21, 14:20

  11. TYPO3com voted on patch set 3 V +1 04/20/21, 14:26 Completed build in 05m 48s on Tue, 20 Apr, 02:26 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10763

  12. core-ci voted on patch set 3 V +1 04/20/21, 14:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2374

  13. Benni Mack updated the commit message in patch set 4 04/20/21, 15:17

  14. TYPO3com voted on patch set 4 V +1 04/20/21, 15:29 Completed build in 11m 37s on Tue, 20 Apr, 03:29 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10766

  15. core-ci voted on patch set 4 V +1 04/20/21, 15:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2377

  16. Jochen Roth commented on patch set 4 V -1 04/20/21, 15:48

    -1 for now, because on right click it opens the OS context menu on top of typo3s context menu
  17. Benni Mack uploaded patch set 5 04/21/21, 07:43

  18. TYPO3com voted on patch set 5 V +1 04/21/21, 07:49 Completed build in 06m 09s on Wed, 21 Apr, 07:49 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10772

  19. core-ci voted on patch set 5 V +1 04/21/21, 07:54 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2386

  20. Ayke Halder voted on patch set 5 CR +1 04/21/21, 09:25

  21. Jochen Roth voted on patch set 5 V +1 CR +1 04/21/21, 11:50

  22. Oli Bartsch voted on patch set 5 V +1 CR +1 04/21/21, 21:22

  23. Benni Mack voted on patch set 5 V +2 CR +2 04/22/21, 05:41

  24. Benni Mack merged patch set 6 04/22/21, 05:42