Review 9.5 Merged

68801[BUGFIX] Include IP in authentication logs

Markus Klein CR +2 V +2 Easy +3 −4 updated 04/23/21, 08:34

Commit message

Logs written via the logging API now include the correct
remote address instead of the marker ###IP###.

Additionally, some actions were logged twice, this is
streamlined.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Wouter Wolters +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 1

Review log 610

  1. Markus Klein uploaded patch set 1 04/19/21, 10:48

  2. Markus Klein updated the commit message in patch set 2 04/19/21, 10:48

  3. TYPO3com voted on patch set 1 V +1 04/19/21, 10:57 Completed build in 08m 56s on Mon, 19 Apr, 10:57 AM Test Summary: 75703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1052

  4. TYPO3com voted on patch set 2 V +1 04/19/21, 11:00 Completed build in 12m 00s on Mon, 19 Apr, 11:00 AM Test Summary: 75703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1053

  5. core-ci voted on patch set 1 V +1 04/19/21, 11:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2329

  6. core-ci voted on patch set 2 V +1 04/19/21, 11:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2330

  7. Torben Hansen voted on patch set 2 CR +1 04/19/21, 11:21

  8. Wouter Wolters voted on patch set 2 CR +1 04/20/21, 19:22

  9. Richard Haeser commented on patch set 2 V +2 CR +2 04/23/21, 08:34

    Benni is fine with backport to v9
  10. Richard Haeser merged patch set 3 04/23/21, 08:34