6883[FEATURE] Add error message for missing TCA
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Stefan Neufeind +1
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2
- Steffen Ritter +2
- Georg Ringer +1
Issues 1
Files 3
Review log 40
Show 15 earlier messages
-
Mario Rimann commented on patch set 1 3 comments 02/13/12, 08:18
I would prefer that you didn't submit this I'll come up with an updated patch. -
Mario Rimann uploaded patch set 2 02/13/12, 08:18
-
Mario Rimann commented on patch set 2 02/13/12, 08:18
(1 inline comment) @Dmitry: What about doing both? Keep the flash message to annoy the developer while he's developing AND write a log entry at the same moment? I basically agree to "user should not see error message", but then let's just change the text to make clear that it's a technical problem where the user cannot do anything for it (IMHO an extension that throws this error should not have been released to a regular user anyway, right?) -
Mario Rimann commented on patch set 2 02/13/12, 08:18
@Dmitry: Yes, seems to be related to the same source of problems - what to do? I basically like the flash error message approach more, since it makes the developer aware of the problem in a more prominent way than just logging. (my opinion) -
Tolleiv Nietsch commented on patch set 3 02/13/12, 08:18
I would prefer that you didn't submit this I have to agree with Dmitry - that's nothing which should irritate a user. I'd suggest to show these FlashMessages only if backend debugging is enabled otherwise they should imho be kept hidden. -
Mario Rimann uploaded patch set 3 02/13/12, 08:18
-
Mario Rimann commented on patch set 3 02/13/12, 08:18
Patch Set 3 just changes the error message to be a statement and not a question. -
Mario Rimann uploaded patch set 4 02/13/12, 08:18
-
Dmitry Dulepov commented on patch set 2 02/13/12, 08:18
(1 inline comment) Mario, that's developer's approach ;) With log, admins can see them and take care. With flash message users will see cryptic errors and wonder what *they* did wrong. It is not a message that the ordinary user should see. -
Dmitry Dulepov commented on patch set 2 02/13/12, 08:18
Could you imagine your phone telling you something like "Missing language string with identifier GSM.connection.phase.3 in the system module adslwab.dyld" each time when you call somebody? :) Another good example of such messages is here: http://www.tamba2.org.uk/T2/2007/08/16/opaque-error-messages/ What would you do, when you get such message? Shrug and close it, feel discomfort, right? So it is not useful to show that to users. :) That's why every OS gets it in the log. For example, my error log is full of: "kernel: IOSurface: buffer allocation size is zero". That's most likely a error. But, as a user, I do not care: the system works and I am happy it does not bug me with technical messages while I am in the middle of my work. As soon as the system can handle it without me, it is ok. If the system starts crashing or does not work as expected, I'll have a look to logs and investigate. -
Dmitry Dulepov commented on patch set 2 02/13/12, 08:18
Warning: conflicts with https://review.typo3.org/6893. -
Dmitry Dulepov commented on patch set 4 02/13/12, 08:18
(1 inline comment) -
Michael Stucki commented on patch set 5 02/13/12, 08:18
Make sure to rebase the change again on current master, otherwise this may give a conflict because of the missing linkvalidator folder (it got replaced by a subproject meanwhile). -
Dmitry Dulepov uploaded patch set 5 02/13/12, 08:18
-
Dmitry Dulepov commented on patch set 5 02/13/12, 08:18
I updated the patch with the following: - linkvalidator is now a submodule. So cherry-pick should be correct now (it was not clean before) - I added missing wrapInHelp - I added a variable and a phpDoc comment to remove some PhpStorm warnings Otherwise it is the same as patch v4.
-
Dmitry Dulepov commented on patch set 5 02/13/12, 08:18
Verified; Looks good to me, approved -
Dmitry Dulepov commented on patch set 5 02/13/12, 08:18
(1 inline comment) -
Stefan Neufeind commented on patch set 5 02/13/12, 08:18
Looks good to me, but someone else must approve will roll in the suggested changes @Oliver: please review your vote then - your corrections will be in with the next revision -
Stefan Neufeind uploaded patch set 6 02/13/12, 08:18
-
Stefan Neufeind commented on patch set 7 02/13/12, 08:18
Philipp: how about the merge? 6893 is targeted as a bugfix down to 4.5 while this here is a new feature for 4.7 then. Could you please have a look at this patch and make up your mind about the -1 you gave? -
Stefan Neufeind uploaded patch set 7 02/13/12, 08:18
-
Stefan Neufeind commented on patch set 7 02/13/12, 08:18
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 5 8 comments 02/13/12, 08:18
I would prefer that you didn't submit this -
Oliver Klee commented on patch set 7 02/13/12, 08:18
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 1 02/13/12, 08:18
I would prefer that you didn't submit thisclass.db_list_extra.inc:352CGL, tabclass.db_list_extra.inc:3531st) use a flashmessage for that 2nd) use translations. there were *hard* efforts to localize as much as possible, so no hardcoding english texts 3rd) cglclass.db_list_extra.inc:586cgl -
Georg Ringer commented on patch set 7 1 comment 02/13/12, 08:18
Verified; Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 7 V 0 02/13/12, 08:18
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 7 02/13/12, 08:18
I would prefer that you didn't submit this Actually https://review.typo3.org/#change,6893 should be merged into this one. (Or the other way around.) Displaying a flashmessage will help the developer if he turns on ['BE']['debug'] = 1. Additionally such error should be logged. -
Philipp Gampe commented on patch set 7 02/13/12, 08:18
No score ok, merge the bugfix first and then adapt this one, I just did not want to have to concurring patches for the same code. -
Simon Schaufelberger commented on patch set 2 02/13/12, 08:18
ups, sorry, i was misreading it. In my opinion the question should still be turned into a clear "message"locallang_mod_web_list.xlf:151correct englisch would be "has been found". I would not write a question here. TYPO3 must be clear in error messages. -
Simon Schaufelberger commented on patch set 2 1 comment 02/13/12, 08:18
I would prefer that you didn't submit this -
Simon Schaufelberger commented on patch set 3 02/13/12, 08:18
Looks good to me, but someone else must approve looks much better! -
Mr. Jenkins commented on patch set 1 02/13/12, 08:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2485/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/13/12, 08:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2494/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/13/12, 08:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2564/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/13/12, 08:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2612/ : SUCCESS -
Mr. Jenkins commented on patch set 5 02/13/12, 08:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2615/ : SUCCESS -
Mr. Jenkins commented on patch set 6 02/13/12, 08:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2823/ : SUCCESS -
Mr. Jenkins commented on patch set 7 02/13/12, 08:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2824/ : SUCCESS -
Steffen Ritter merged patch set 7 02/13/12, 08:18