Review main Merged

68832[BUGFIX] Display correct message if slug suggestion is modified

Benni Mack CR +2 V +2 Easy +5 −5 updated 04/21/21, 08:02

Commit message

If a user enters a slug proposal, which is already taken by
another page in the same site, the automatically modified
slug is now shown along with the corresponding message.

The actual functionality already existed, but was never used
due to a Bug in the AJAX response.

In addition, the label for the warning message does not have
the base / slug at the very end, so sprintf() must be used
AFTER htmlspecialchars().

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 711

  1. Benni Mack uploaded patch set 1 04/20/21, 08:10

  2. TYPO3com voted on patch set 1 V +1 04/20/21, 08:17 Completed build in 07m 24s on Tue, 20 Apr, 08:17 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10744

  3. core-ci voted on patch set 1 V +1 04/20/21, 08:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2355

  4. Oli Bartsch updated the commit message in patch set 2 04/20/21, 08:42

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 04/20/21, 08:42

  6. TYPO3com voted on patch set 2 V +1 04/20/21, 08:50 Completed build in 08m 00s on Tue, 20 Apr, 08:50 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10748

  7. core-ci voted on patch set 2 V +1 04/20/21, 08:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2359

  8. Anja Leichsenring voted on patch set 2 V +1 CR +1 04/20/21, 17:30

  9. Wouter Wolters voted on patch set 2 CR +1 04/20/21, 19:14

  10. Benni Mack voted on patch set 2 V +2 CR +2 04/21/21, 08:01

  11. Benni Mack merged patch set 3 04/21/21, 08:02