Review main Merged

68833[BUGFIX] Optimize drag&drop of folders in the UI

Jochen Roth CR +2 V +2 Easy +5 −4 updated 04/20/21, 09:17

Commit message

Allow a user to move a folder into a folder on the same
level and prevent moving a folder into its child folder.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 915

  1. Jochen Roth uploaded patch set 1 04/20/21, 08:15

  2. Mathias Brodala updated the commit message in patch set 2 04/20/21, 08:18

  3. TYPO3com voted on patch set 1 V +1 04/20/21, 08:22 Completed build in 06m 53s on Tue, 20 Apr, 08:22 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10745

  4. TYPO3com voted on patch set 2 V +1 04/20/21, 08:24 Completed build in 06m 12s on Tue, 20 Apr, 08:24 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10746

  5. core-ci voted on patch set 1 V +1 04/20/21, 08:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2356

  6. core-ci voted on patch set 2 V +1 04/20/21, 08:36 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2357

  7. Benni Mack commented on patch set 2 CR +1 04/20/21, 08:42

    backport won't be possible, since this was only added in v11
  8. Benni Mack updated the commit message in patch set 3 04/20/21, 08:43

  9. Benni Mack voted on patch set 3 V +1 CR +1 04/20/21, 08:43

  10. Mathias Brodala commented on patch set 3 04/20/21, 08:46

    Reply

    I see, didn't check, sorry.
  11. Oli Bartsch voted on patch set 3 V +1 CR +1 04/20/21, 08:48

  12. TYPO3com voted on patch set 3 V +1 04/20/21, 08:50 Completed build in 06m 56s on Tue, 20 Apr, 08:50 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10749

  13. core-ci voted on patch set 3 V +1 04/20/21, 09:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2360

  14. Benni Mack voted on patch set 3 V +2 CR +2 04/20/21, 09:17

  15. Benni Mack merged patch set 4 04/20/21, 09:17