Review main Merged

68834[TASK] Activate phpstan option reportUnmatchedIgnoredErrors

Daniel Goerz CR +2 V +2 Normal +62 −117 updated 04/21/21, 07:44

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 814

  1. Daniel Goerz uploaded patch set 1 04/20/21, 08:43

  2. TYPO3com voted on patch set 1 V -1 04/20/21, 08:43 Completed build in 18s on Tue, 20 Apr, 08:43 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10750

  3. Daniel Goerz rebased onto patch set 2 04/20/21, 08:47

  4. TYPO3com commented on patch set 2 04/20/21, 08:47 Completed build in 18s on Tue, 20 Apr, 08:47 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10751

  5. Daniel Goerz wrote 04/20/21, 08:47

    Topic set to phpstan
  6. core-ci voted on patch set 1 V +1 04/20/21, 09:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2361

  7. core-ci commented on patch set 2 04/20/21, 09:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2362

  8. Daniel Goerz rebased onto patch set 3 04/20/21, 17:47

  9. TYPO3com voted on patch set 3 V +1 04/20/21, 17:56 Completed build in 08m 53s on Tue, 20 Apr, 05:56 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10768

  10. core-ci voted on patch set 3 V +1 04/20/21, 17:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2379

  11. Wouter Wolters voted on patch set 3 CR +1 04/20/21, 19:11

  12. Jochen Roth voted on patch set 3 V +1 CR +1 04/21/21, 07:25

  13. Benni Mack voted on patch set 3 V +2 CR +2 04/21/21, 07:43

  14. Benni Mack merged patch set 4 04/21/21, 07:44