Review main Merged

68835[BUGFIX] Re-add highlighting of filter term in Svg Tree

Benni Mack CR +2 V +2 Easy +23 −5 updated 04/23/21, 08:37

Commit message

This change re-adds the highlighting of filter
results in the Svg Trees, which was present
before in the Page Tree before it was built on SVG.

Due to the nature of SVG, it is rather complicated
to color the actual background of the text than the
text itself (using <tspan>), but still, the highlighting
is IMHO better than having no highlighting.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 611

  1. Benni Mack uploaded patch set 1 04/20/21, 15:47

  2. TYPO3com voted on patch set 1 V -1 04/20/21, 15:53 Completed build in 06m 15s on Tue, 20 Apr, 03:53 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10767

  3. core-ci voted on patch set 1 V -1 04/20/21, 15:58 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2378

  4. Richard Haeser uploaded patch set 2 04/20/21, 18:56

  5. TYPO3com voted on patch set 2 V +1 04/20/21, 19:02 Completed build in 06m 24s on Tue, 20 Apr, 07:02 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10769

  6. core-ci voted on patch set 2 V +1 04/20/21, 19:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2380

  7. Benni Mack uploaded patch set 3 04/22/21, 21:21

  8. TYPO3com voted on patch set 3 V +1 04/22/21, 21:29 Completed build in 07m 04s on Thu, 22 Apr, 09:29 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10817

  9. Oli Bartsch commented on patch set 3 V +1 CR +1 04/22/21, 22:09

    Yes, definitely an improvement. Thanks.
  10. Richard Haeser voted on patch set 3 V +2 CR +2 04/23/21, 07:24

  11. Benni Mack merged patch set 4 04/23/21, 08:37