Review main Merged

68836[TASK] Inform about disallowed file extension in image ViewHelpers

Richard Haeser CR +2 V +2 Easy +22 −6 updated 04/26/21, 07:30

Commit message

Throws an exception when a file extension is given to the image
or media ViewHelpers which is not within the allowed image file
extensions.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Kevin Appelt +1
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Kevin Appelt +1
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 2032

Show 47 earlier messages
  1. Richard Haeser uploaded patch set 1 04/21/21, 08:06

  2. Oli Bartsch commented on patch set 1 04/21/21, 08:08

    ImageViewHelper.php:155

    Could we use strict types for in_array?
  3. Richard Haeser uploaded patch set 2 04/21/21, 08:10

  4. Richard Haeser commented on patch set 2 04/21/21, 08:10

    ImageViewHelper.php:155 Reply

    Done
  5. TYPO3com voted on patch set 1 V +1 04/21/21, 08:14 Completed build in 07m 31s on Wed, 21 Apr, 08:14 AM Test Summary: 33309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10774

  6. TYPO3com voted on patch set 2 V +1 04/21/21, 08:17 Completed build in 06m 16s on Wed, 21 Apr, 08:17 AM Test Summary: 33309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10775

  7. core-ci voted on patch set 1 V +1 04/21/21, 08:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2388

  1. core-ci voted on patch set 2 V +1 04/21/21, 08:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2389

  2. Benni Mack commented on patch set 2 04/21/21, 08:40

    should we just do logging in v10? and throw exceptions in v11?
  3. Mathias Brodala commented on patch set 2 04/21/21, 09:56

    ImageViewHelper.php:155

    You could use GeneralUtility::inList() instead here.

    ImageViewHelper.php:156

    We should mention $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext'] here for easier fixing.
  4. Richard Haeser uploaded patch set 3 04/21/21, 12:06

  5. Richard Haeser commented on patch set 2 04/21/21, 12:06

    Reply

    Seems like a good idea!

    ImageViewHelper.php:155 Reply

    Done

    ImageViewHelper.php:156 Reply

    Done
  6. TYPO3com voted on patch set 3 V +1 04/21/21, 12:14 Completed build in 07m 50s on Wed, 21 Apr, 12:14 PM Test Summary: 33309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10776

  7. Mathias Brodala commented on patch set 3 04/21/21, 12:17

    ImageViewHelper.php:155

    We can use inList() here too ...

    ImageViewHelper.php:156

    The exception here should be the same as in the other viewhelper.
  8. core-ci voted on patch set 3 V +1 04/21/21, 12:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2390

  9. Richard Haeser uploaded patch set 4 04/21/21, 12:20

  10. Richard Haeser commented on patch set 4 04/21/21, 12:21

    Wow, that was a classic. Pushed to fast...

    ImageViewHelper.php:155 Reply

    Done

    ImageViewHelper.php:156 Reply

    Done
  11. TYPO3com voted on patch set 4 V +1 04/21/21, 12:26 Completed build in 05m 53s on Wed, 21 Apr, 12:26 PM Test Summary: 33309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10777

  12. Mathias Brodala voted on patch set 4 CR +1 04/21/21, 12:31

  13. core-ci voted on patch set 4 V +1 04/21/21, 12:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2391

  14. Kevin Appelt commented on patch set 4 V -1 CR -1 04/21/21, 18:46

    MediaViewhelper does not have the check yet. I am on it.
  15. Kevin Appelt uploaded patch set 5 04/21/21, 18:53

  16. TYPO3com voted on patch set 5 V +1 04/21/21, 19:00 Completed build in 06m 25s on Wed, 21 Apr, 07:00 PM Test Summary: 33309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10786

  17. core-ci voted on patch set 5 V +1 04/21/21, 19:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10583

  18. Benni Mack updated the commit message in patch set 6 04/22/21, 06:57

  19. TYPO3com voted on patch set 6 V +1 04/22/21, 07:03 Completed build in 05m 40s on Thu, 22 Apr, 07:03 AM Test Summary: 33309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10792

  20. core-ci voted on patch set 6 V +1 04/22/21, 07:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10589

  21. Kevin Appelt commented on patch set 6 V +1 CR +1 04/22/21, 08:45

    Seems fine to me now 😊
  22. Richard Haeser voted on patch set 6 V +1 04/22/21, 11:41

  23. Benni Mack voted on patch set 6 V +1 CR +1 04/23/21, 19:53

  24. Richard Haeser voted on patch set 6 V +2 CR +2 04/26/21, 07:30

  25. Richard Haeser merged patch set 7 04/26/21, 07:30