Review main Merged

68839[BUGFIX] Hide tooltip after scrolling

Jochen Roth CR +2 V +2 Easy +18 −12 updated 04/23/21, 16:19

Commit message

Will hide all tooltips when scrolling
in the page tree panel to avoid multiple
tooltips to show up and get stuck on screen

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 916

  1. Jochen Roth uploaded patch set 1 04/21/21, 15:40

  2. Jochen Roth commented on patch set 1 04/21/21, 15:41

    Can you please have a look, not sure if my typescript changes are any good.
  3. TYPO3com voted on patch set 1 V +1 04/21/21, 15:46 Completed build in 06m 20s on Wed, 21 Apr, 03:46 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10784

  4. core-ci voted on patch set 1 V +1 04/21/21, 15:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10581

  5. Jochen Roth uploaded patch set 2 04/22/21, 07:45

  6. TYPO3com voted on patch set 2 V +1 04/22/21, 07:52 Completed build in 06m 57s on Thu, 22 Apr, 07:52 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10793

  7. core-ci voted on patch set 2 V +1 04/22/21, 07:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10590

  8. Oliver Hader commented on patch set 2 V +1 CR +1 04/23/21, 12:51

    Much better, thx. Tested with local rebuild - probably let's wait until https://review.typo3.org/c/Packages/TYPO3.CMS/+/68104 is merged and then continue with this one again.
  9. Jochen Roth uploaded patch set 3 04/23/21, 13:36

  10. TYPO3com voted on patch set 3 V +1 04/23/21, 13:44 Completed build in 07m 29s on Fri, 23 Apr, 01:44 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10833

  11. Oli Bartsch rebased onto patch set 4 04/23/21, 14:30

  12. TYPO3com voted on patch set 4 V +1 04/23/21, 14:38 Completed build in 07m 11s on Fri, 23 Apr, 02:38 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10837

  13. core-ci voted on patch set 4 V +1 04/23/21, 14:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10654

  14. Oli Bartsch voted on patch set 4 V +1 CR +1 04/23/21, 14:53

  15. Oliver Hader voted on patch set 4 V +2 CR +2 04/23/21, 16:19

  16. Oliver Hader merged patch set 5 04/23/21, 16:19