Review main Merged

68840[BUGFIX] Use live record for diff view

Oli Bartsch CR +2 V +2 Easy +7 −15 updated 04/27/21, 17:14

Commit message

The diff view for new and deleted placeholder records,
introduced in #93620, used the current version record
for the generation of the diff view.

Since corresponding relations (live and version) do always
contain the live records' uid as foreign_field value, the diff
view generation must also use the live record. Especially
since this does not make any difference when dealing with
new or delete placeholder.

Note: New placeholders were removed in v11, so this fix only
applies to delete placeholders in v11.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 713

  1. Oli Bartsch uploaded patch set 1 04/21/21, 21:18

  2. TYPO3com voted on patch set 1 V +1 04/21/21, 21:26 Completed build in 08m 45s on Wed, 21 Apr, 09:26 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10787

  3. core-ci voted on patch set 1 V +1 04/21/21, 21:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10584

  4. Oli Bartsch updated the commit message in patch set 2 04/22/21, 13:47

  5. Oli Bartsch updated the commit message in patch set 3 04/22/21, 13:53

  6. TYPO3com voted on patch set 2 V +1 04/22/21, 13:56 Completed build in 08m 49s on Thu, 22 Apr, 01:56 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10805

  7. core-ci voted on patch set 2 V +1 04/22/21, 13:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10603

  8. TYPO3com voted on patch set 3 V +1 04/22/21, 14:01 Completed build in 08m 41s on Thu, 22 Apr, 02:01 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10806

  9. core-ci voted on patch set 3 V +1 04/22/21, 14:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10605

  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 04/27/21, 17:09

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 04/27/21, 17:10

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 04/27/21, 17:13

  13. Oli Bartsch merged patch set 4 04/27/21, 17:14