Review main Merged

68841[TASK] Apply dark style to module menu scrollbar

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 04/08/22, 11:50

Commit message

The default light system-ui scrollbars are very distracting on
the dark module menu surface. Therefore they are now replaced
by a more appealing dark-mode scrollbar style, as provided
by the browser vendor.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Björn Jacob +1
    • Jonas Eberle +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Björn Jacob +1
    • Jonas Eberle +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2635

Show 510 earlier messages
  1. Benjamin Franzke uploaded patch set 1 04/22/21, 08:06

  2. TYPO3com voted on patch set 1 V +1 04/22/21, 08:14 Completed build in 08m 08s on Thu, 22 Apr, 08:14 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10794

  3. core-ci voted on patch set 1 V +1 04/22/21, 08:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10591

  4. Benjamin Franzke uploaded patch set 2 08/31/21, 08:44

  5. Benjamin Franzke commented on patch set 2 08/31/21, 08:44

    This change is ready for review.
  6. core-ci voted on patch set 2 V +1 08/31/21, 08:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15914

  7. Benjamin Franzke uploaded patch set 3 09/16/21, 21:38

    Rebase
  8. core-ci voted on patch set 3 V +1 09/16/21, 21:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16832

  9. Benjamin Franzke uploaded patch set 4 10/01/21, 18:01

  10. core-ci voted on patch set 4 V +1 10/01/21, 18:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17457

  1. Oli Bartsch commented on patch set 4 CR -1 10/01/21, 20:32

    While I like the change of introducing a common scrollbar between browsers, the added space between the menu items and the scrollbar seems to big. Furthermore does the module menu "jump" when the scrollbar gets visible. I added a screenshot and a video to the issue.
    For me, both scrollbars are now always visible
  2. Benjamin Franzke marked it work in progress 10/01/21, 23:42

  3. Jonas Eberle uploaded patch set 5 11/04/21, 15:30

  4. Jonas Eberle commented on patch set 5 V +1 CR -1 11/04/21, 15:38

    This drastically improves the look on Chromium. The scrollbars are shown always, though. I would be fine with changing the commit message in that regard. The mentioned problem with spacing around the icon column (when collapsed) is indeed a problem but unrelated. Current state of master is that the layout only looks fine on Chrome. I tried to deal with it here https://review.typo3.org/c/Packages/TYPO3.CMS/+/71795 but only managed a "compromise".
  5. core-ci voted on patch set 5 V +1 11/04/21, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18898

  6. Benni Mack wrote 11/29/21, 10:14

    Change destination moved from master to main
  7. Benni Mack updated the commit message in patch set 6 11/29/21, 13:39

  8. core-ci voted on patch set 6 V +1 11/29/21, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20069

  9. Benjamin Franzke uploaded patch set 7 04/07/22, 16:43

  10. Benjamin Franzke commented on patch set 7 04/07/22, 16:47

    Reply

    Ok, will stay from touching that region. Browsers start to implement that pattern on their own, so need for us to show the scrollbar on hover. I'll rather go with a simple `color-scheme: dark` now.
  11. Simon Schaufelberger voted on patch set 7 V +1 CR +1 04/07/22, 16:48

  12. core-ci voted on patch set 7 V +1 04/07/22, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25777

  13. Benjamin Franzke wrote 04/07/22, 17:08

    Topic set to experimental UI
  14. Benjamin Franzke wrote 04/07/22, 17:09

    Topic experimental UI removed
  15. Benjamin Franzke wrote 04/07/22, 17:10

    Topic set to ui
  16. Jonas Eberle commented on patch set 7 V +1 CR +1 04/07/22, 19:15

    That's really nice. It keeps the native beauty of Firefox's use of system libs and looks very good with Chromium/Blink. I checked Edge/Webkit and Safari 15 (continues to use native libs) through Browserstack. Thanks!
  17. Björn Jacob voted on patch set 7 V +1 CR +1 04/07/22, 19:32

  18. Stefan Bürk voted on patch set 7 V +1 CR +1 04/07/22, 21:57

  19. Benjamin Franzke uploaded patch set 8 04/08/22, 08:57

    Resolve Merge Conflict
  20. core-ci voted on patch set 8 V +1 04/08/22, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25818

  21. Björn Jacob voted on patch set 8 V +1 CR +1 04/08/22, 09:11

  22. Stefan Bürk voted on patch set 8 V +1 CR +1 04/08/22, 09:46

  23. Jonas Eberle voted on patch set 8 V +1 CR +1 04/08/22, 10:16

  24. Benjamin Franzke voted on patch set 8 V +2 CR +2 04/08/22, 11:50

  25. Benjamin Franzke merged patch set 9 04/08/22, 11:50