Review main Merged

68842[TASK] Use %currentWorkingDirectory% in phpstan config files

Alexander Schnitzler CR +2 V +2 Easy +24 −24 updated 04/22/21, 12:54

Commit message

To avoid issues due to relative paths in config files, all
paths are now prepended with the %currentWorkingDirectory%
variable of phpstan. That way, the exact environment of
config files is irrelevant.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Alexander Schnitzler uploaded patch set 1 04/22/21, 10:51

  2. Alexander Schnitzler wrote 04/22/21, 10:51

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V +1 04/22/21, 10:58 Completed build in 07m 18s on Thu, 22 Apr, 10:58 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10796

  4. Daniel Goerz voted on patch set 1 V +1 CR +1 04/22/21, 11:08

  5. Daniel Goerz commented on patch set 1 04/22/21, 11:08

    Thanks!
  6. core-ci voted on patch set 1 V +1 04/22/21, 11:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10593

  7. Oli Bartsch voted on patch set 1 V +1 CR +1 04/22/21, 11:30

  8. Daniel Goerz voted on patch set 1 V +2 CR +2 04/22/21, 12:54

  9. Daniel Goerz merged patch set 2 04/22/21, 12:54