Review 10.4 Merged

68844[BUGFIX] Use live record for diff view

Oli Bartsch CR +2 V +2 Easy +7 −15 updated 04/27/21, 17:15

Commit message

The diff view for new and deleted placeholder records,
introduced in #93620, used the current version record
for the generation of the diff view.

Since corresponding relations (live and version) do always
contain the live records' uid as foreign_field value, the diff
view generation must also use the live record. Especially
since this does not make any difference when dealing with
new or delete placeholder.

Note: New placeholders were removed in v11, so this fix only
applies to delete placeholders in v11.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 04/22/21, 13:52

  2. TYPO3com voted on patch set 1 V +1 04/22/21, 14:00 Completed build in 08m 03s on Thu, 22 Apr, 02:00 PM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1326

  3. core-ci voted on patch set 1 V +1 04/22/21, 14:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10604

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 04/27/21, 17:09

  5. Christian Kuhn voted on patch set 1 V 0 CR 0 04/27/21, 17:10

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 04/27/21, 17:14

  7. Oli Bartsch merged patch set 2 04/27/21, 17:15