68846[WIP][FEATURE] Introduce ActiveExtensions API in favor of PackageStates
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 3
Review log 610
-
Benni Mack uploaded patch set 1 04/23/21, 10:16
-
TYPO3com voted on patch set 1 V -1 04/23/21, 10:16 Completed build in 10s on Fri, 23 Apr, 10:16 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10822
-
core-ci voted on patch set 1 V -1 04/23/21, 10:17 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10630
-
Benni Mack updated the commit message in patch set 2 04/23/21, 10:20
-
TYPO3com voted on patch set 2 V -1 04/23/21, 10:20 Completed build in 18s on Fri, 23 Apr, 10:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10823
-
core-ci voted on patch set 2 V -1 04/23/21, 10:22 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10631
-
Helmut Hummel commented on patch set 2 04/26/21, 09:27
-
Jochen Roth commented on patch set 2 04/27/21, 07:11
ActiveExtensionsTrait.php:60Reply UnresolvedNot sure if i got you right. This extensions array should look like this? private array $extensions = [ 'typo3/cms-core' => [ 'extKey' => 'core', 'composerPackage' => 'typo3/cms-core', 'version' => 'dev-master', 'path' => '/Volumes/Development/typo3-dev-composer/public/typo3/sysext/core', ], ] The additional map array should like this? private array $packageMapIncludingReplacements = [ 'typo3/cms-adminpanel' => 'typo3/cms-adminpanel', 'typo3-ter/news' => 'georgringer/news', // replace setion from composer.json 'georgringer/news' => 'georgringer/news' ] I would suggest to add a additional extension->packageName map (maybe just for now): private array $extKeyPackageMap = [ 'adminpanel' => 'typo3/cms-adminpanel', ] So we can still get packages by extension key. Feel free to text me on slack -
Benjamin Franzke commented on patch set 2 04/29/21, 17:13
I would really love if we'd just parse vendor/composer/installed.json (what a pity that's not defined as API) in PackageManager (of course only in composer mode) and cache that via our caching frameework. No dynamic class generation, no composer plugin-fu (please remember how unstable updates of composer plugins are/were), contains all we need (even the "extra" section that PackageManager usually reads from composer.json), and it could simply be cache-warmed together with all other caches via https://review.typo3.org/c/Packages/TYPO3.CMS/+/61645 -
Benni Mack abandoned the change 08/04/21, 11:16
ActiveExtensionsTrait.php:60