Review main Merged

68849[BUGFIX] Fix PageTreeFilterCest

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 04/23/21, 14:30

Commit message

The SvgTree markup changed in #87743 causing
acceptance test failures.
This wasn't discovered as gitlab-ci missed to vote negative.

The text node for the page "inline mngroup" now
contains additional HTML when filtering for "Group".
This new markup rendered the previous xpath invalid:

  inline mn<tspan class="node-highlight-text">group</tspan>

The xpath is now adapted to only filter for the text node.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 1

Review log 812

  1. Benjamin Franzke uploaded patch set 1 04/23/21, 14:03

  2. TYPO3com voted on patch set 1 V +1 04/23/21, 14:11 Completed build in 08m 06s on Fri, 23 Apr, 02:11 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10835

  3. Oliver Hader voted on patch set 1 CR +1 04/23/21, 14:14

  4. core-ci voted on patch set 1 V +1 04/23/21, 14:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10652

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 04/23/21, 14:16

  6. Oliver Hader commented on patch set 1 V +1 CR -1 04/23/21, 14:17

    pagee ;)
  7. Benjamin Franzke updated the commit message in patch set 2 04/23/21, 14:18

  8. Oliver Hader voted on patch set 2 V +1 CR +1 04/23/21, 14:18

  9. TYPO3com voted on patch set 2 V +1 04/23/21, 14:24 Completed build in 06m 20s on Fri, 23 Apr, 02:24 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10836

  10. core-ci voted on patch set 2 V +1 04/23/21, 14:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10653

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 04/23/21, 14:29

  12. Oli Bartsch merged patch set 3 04/23/21, 14:30