Review main Merged

68850[TASK] Update phpstan/phpstan

Alexander Schnitzler CR +2 V +2 Hard +212 −102 updated 04/27/21, 17:11

Commit message

Update phpstan to version 0.12.84 and fix new issues
detected by the new version.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 1321

  1. Alexander Schnitzler uploaded patch set 1 04/23/21, 15:17

  2. Alexander Schnitzler wrote 04/23/21, 15:17

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V -1 04/23/21, 15:25 Completed build in 08m 03s on Fri, 23 Apr, 03:25 PM Test Summary: 33306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10840

  4. core-ci voted on patch set 1 V -1 04/23/21, 15:28 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10657

  5. Alexander Schnitzler uploaded patch set 2 04/23/21, 15:35

  6. TYPO3com voted on patch set 2 V +1 04/23/21, 15:41 Completed build in 06m 15s on Fri, 23 Apr, 03:41 PM Test Summary: 33305 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10841

  7. core-ci voted on patch set 2 V +1 04/23/21, 15:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10658

  8. Alexander Schnitzler commented on patch set 2 04/23/21, 15:53

    TcaSelectItems.php:298 Unresolved

    This needs to be checked manually.
  9. Alexander Schnitzler uploaded patch set 3 04/23/21, 15:55

  10. TYPO3com voted on patch set 3 V +1 04/23/21, 16:03 Completed build in 07m 50s on Fri, 23 Apr, 04:03 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10843

  11. core-ci voted on patch set 3 V +1 04/23/21, 16:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10660

  12. Daniel Goerz voted on patch set 3 CR +1 04/23/21, 18:34

  13. Alexander Schnitzler commented on patch set 3 04/24/21, 12:19

    This change is ready for review.
  14. Christian Kuhn rebased onto patch set 4 04/27/21, 16:26

  15. core-ci voted on patch set 4 V +1 04/27/21, 16:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10746

  16. Christian Kuhn commented on patch set 4 CR -1 04/27/21, 16:39

    on it.
  17. Christian Kuhn uploaded patch set 5 04/27/21, 16:57

  18. Christian Kuhn voted on patch set 5 V +1 CR +1 04/27/21, 17:01

  19. core-ci voted on patch set 5 V +1 04/27/21, 17:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10749

  20. Anja Leichsenring voted on patch set 5 V +2 CR +2 04/27/21, 17:11

  21. Anja Leichsenring merged patch set 6 04/27/21, 17:11