Review 9.5 Merged

68867[BUGFIX] Do not download artifacts in gitlab voting stage

Christian Kuhn CR +2 V +2 Easy +4 −0 updated 04/28/21, 23:43

Commit message

By default, gitlab passes all artifacts from previous
stages to each job. Thus, the negative-vote job was not
executed in case previous jobs with artifacts failed.

Since those jobs don't need artifacts anyways, not
downloading them solves the issue.

See: https://docs.gitlab.com/ee/ci/yaml/README.html#dependencies

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 04/28/21, 23:27

    Cherry Picked from branch 10.4.
  2. core-ci voted on patch set 1 V +1 04/28/21, 23:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10870

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 04/28/21, 23:43

  4. Christian Kuhn merged patch set 2 04/28/21, 23:43