68872[BUGFIX] Improve mocking for doctrine/dbal related tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Simon Gilli +1
- Torben Hansen +1
-
Verified V +2 Done
- Christian Kuhn +2
- Simon Gilli +1
- Torben Hansen +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+9 −8
- typo3/sysext/extbase/Tests/Functional/Service/Fixtures/tt_content_with_single_plugin.xmlnew+10 −0
- typo3/sysext/extbase/Tests/Functional/Service/Fixtures/tt_content_with_two_plugins.xmlnew+17 −0
- typo3/sysext/extbase/Tests/Functional/Service/ExtensionServiceTest.php+97 −17
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+0 −78
Review log 814
-
Anja Leichsenring uploaded patch set 1 04/25/21, 08:06
-
TYPO3com voted on patch set 1 V -1 04/25/21, 08:06 Completed build in 09s on Sun, 25 Apr, 08:06 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10856
-
Anja Leichsenring uploaded patch set 2 04/25/21, 08:07
-
core-ci voted on patch set 1 V -1 04/25/21, 08:08 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10684
-
TYPO3com voted on patch set 2 V +1 04/25/21, 08:13 Completed build in 05m 52s on Sun, 25 Apr, 08:13 AM Test Summary: 33310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10857
-
core-ci voted on patch set 2 V +1 04/25/21, 08:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10685
-
Anja Leichsenring commented on patch set 2 CR -1 04/25/21, 08:40
I overlooked some tiny bits, will adjust later. -
Anja Leichsenring uploaded patch set 3 04/25/21, 08:45
-
TYPO3com voted on patch set 3 V +1 04/25/21, 08:52 Completed build in 06m 47s on Sun, 25 Apr, 08:52 AM Test Summary: 33310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10858
-
core-ci voted on patch set 3 V +1 04/25/21, 08:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10686
-
Simon Gilli voted on patch set 3 V +1 CR +1 04/25/21, 15:56
-
Torben Hansen voted on patch set 3 V +1 CR +1 04/25/21, 17:16
-
Christian Kuhn voted on patch set 3 V +2 CR +2 04/25/21, 18:03
-
Christian Kuhn merged patch set 4 04/25/21, 18:03