68873[TASK] Validate email address for field "be_users.email"
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Christian Kuhn +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 1
Review log 68
-
Torben Hansen uploaded patch set 1 04/25/21, 11:25
-
TYPO3com voted on patch set 1 V +1 04/25/21, 11:33 Completed build in 07m 33s on Sun, 25 Apr, 11:33 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10859
-
core-ci voted on patch set 1 V +1 04/25/21, 11:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10687
-
Oli Bartsch commented on patch set 1 04/26/21, 16:36
While it's totally valid to add this evaluation, I fear there are already lots of records which may contain some invalid email address string. Those records can then not be saved anymore unless the field is updated. What do you think, should we at least add an Important.RST to inform integrators about this change? -
Christian Kuhn commented on patch set 1 V +1 CR +1 04/27/21, 17:44
Reply
nah. imho fine for master - an admin fiddling with user records would then have to either set the field empty, add a valid address, or change tca. -
Anja Leichsenring voted on patch set 1 V +1 CR +1 04/27/21, 17:47
-
Oli Bartsch voted on patch set 1 V +2 CR +2 04/27/21, 17:47
-
Oli Bartsch merged patch set 2 04/27/21, 17:48