Review main Merged

68873[TASK] Validate email address for field "be_users.email"

Torben Hansen CR +2 V +2 Easy +1 −1 updated 04/27/21, 17:48

Commit message

It is currently possible to save any value to the field
"be_users.email" using the "Backend Users" backend module.

This patch ensures, only a valid email address or an
empty string can be saved.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Torben Hansen uploaded patch set 1 04/25/21, 11:25

  2. TYPO3com voted on patch set 1 V +1 04/25/21, 11:33 Completed build in 07m 33s on Sun, 25 Apr, 11:33 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10859

  3. core-ci voted on patch set 1 V +1 04/25/21, 11:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10687

  4. Oli Bartsch commented on patch set 1 04/26/21, 16:36

    While it's totally valid to add this evaluation, I fear there are already lots of records which may contain some invalid email address string. Those records can then not be saved anymore unless the field is updated. What do you think, should we at least add an Important.RST to inform integrators about this change?
  5. Christian Kuhn commented on patch set 1 V +1 CR +1 04/27/21, 17:44

    Reply

    nah. imho fine for master - an admin fiddling with user records would then have to either set the field empty, add a valid address, or change tca.
  6. Anja Leichsenring voted on patch set 1 V +1 CR +1 04/27/21, 17:47

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 04/27/21, 17:47

  8. Oli Bartsch merged patch set 2 04/27/21, 17:48