Review main Merged

68877[TASK] Clean up legacy tree implementations

Benni Mack CR +2 V +2 Hard +61 −331 updated 04/27/21, 15:13

Commit message

Various code occurrences within the legacy tree implementations,
which were marked as internal are removed
(e.g. the method to evaluate a "PM" query parameter)
as the functionality is not needed anymore, along
with some unused properties as well, which are never evaluated
anymore due to the removal of the methods.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 912

  1. Benni Mack uploaded patch set 1 04/26/21, 17:22

  2. core-ci voted on patch set 1 V +1 04/26/21, 17:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10711

  3. Benni Mack uploaded patch set 2 04/27/21, 13:58

  4. core-ci voted on patch set 2 V +1 04/27/21, 14:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10736

  5. Benni Mack commented on patch set 2 V +2 CR +2 04/27/21, 14:40

    nice work!
  6. Benni Mack voted on patch set 2 V 0 CR 0 04/27/21, 14:40

  7. Benni Mack uploaded patch set 3 04/27/21, 14:42

  8. core-ci voted on patch set 3 V +1 04/27/21, 14:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10737

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 04/27/21, 15:07

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 04/27/21, 15:13

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 04/27/21, 15:13

  12. Christian Kuhn merged patch set 4 04/27/21, 15:13