68879[TASK] Optimize GeneralUtility::validEmail()
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2127
Show 2 earlier messages
-
Oli Bartsch commented on patch set 1 04/27/21, 09:52
-
core-ci voted on patch set 1 V +1 04/27/21, 09:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10726
-
Markus Klein commented on patch set 1 04/27/21, 09:53
LegacyLinkNotationConverter.php:74Reply UnresolvedI fully agree here. Move this to `validEmail` please -
Thomas Löffler uploaded patch set 2 04/27/21, 09:55
-
Mathias Brodala voted on patch set 2 CR +1 04/27/21, 09:59
-
Markus Klein voted on patch set 2 CR +1 04/27/21, 10:05
-
core-ci voted on patch set 2 V +1 04/27/21, 10:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10727
-
Guido Schmechel voted on patch set 2 CR +1 04/27/21, 10:18
-
Christian Kuhn commented on patch set 2 V +1 CR +1 04/27/21, 15:46
well, that's a stupid approach. but effective ... so why not? -
Oli Bartsch updated the commit message in patch set 3 04/27/21, 15:48
-
Mathias Brodala voted on patch set 3 CR +1 04/27/21, 15:58
-
core-ci voted on patch set 3 V +1 04/27/21, 16:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10741
-
Christian Kuhn uploaded patch set 4 04/27/21, 16:05
-
Christian Kuhn commented on patch set 4 04/27/21, 16:08
Actually, there is a better change that does not involve that direct @ check: Simple stop in the validator api as soon as the first check returned false. The first default check is RFCValidator, which parses the email and one of the very first things in there is a check for the @ sign. See my proposed solution. In v10, the RFCValidator is hard-coded and there is no API to extend that, so there is no point for this patch in v10. -
Christian Kuhn updated the commit message in patch set 5 04/27/21, 16:10
-
Christian Kuhn updated the commit message in patch set 6 04/27/21, 16:10
-
Oli Bartsch voted on patch set 6 V +1 CR +1 04/27/21, 16:11
-
core-ci voted on patch set 4 V +1 04/27/21, 16:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10743
-
core-ci voted on patch set 5 V +1 04/27/21, 16:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10744
-
Guido Schmechel wrote 04/27/21, 16:21
Removed reviewer Guido Schmechel. -
core-ci voted on patch set 6 V +1 04/27/21, 16:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10745
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 04/27/21, 17:01
-
Christian Kuhn voted on patch set 6 V +1 CR +1 04/27/21, 17:01
-
Oli Bartsch voted on patch set 6 V +2 CR +2 04/27/21, 17:07
-
Oli Bartsch merged patch set 7 04/27/21, 17:07
LegacyLinkNotationConverter.php:74