Review main Merged

68880[BUGFIX] Use t3ver_oid for workspace evaluation

Oli Bartsch CR +2 V +2 Easy +3 −2 updated 04/27/21, 17:23

Commit message

Since #89122 workspace records are not longer identified
by pid=-1, but by checking for their t3ver_oid value. In case
this is greater 0, we deal with a workspace record.

This patch adjusts a vestige of such an "old" check.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Oli Bartsch uploaded patch set 1 04/27/21, 10:57

  2. core-ci voted on patch set 1 V +1 04/27/21, 11:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10729

  3. Benni Mack uploaded patch set 2 04/27/21, 11:31

  4. Benni Mack voted on patch set 2 V +1 CR +1 04/27/21, 11:31

  5. core-ci voted on patch set 2 V +1 04/27/21, 11:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10731

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 04/27/21, 15:28

  7. Christian Kuhn voted on patch set 2 V 0 CR 0 04/27/21, 15:30

  8. Christian Kuhn commented on patch set 2 CR -1 04/27/21, 15:37

    this has quite some impact, especially the workspaceOl() call now. not sure for now.
  9. Oli Bartsch uploaded patch set 3 04/27/21, 15:46

  10. Oli Bartsch commented on patch set 3 04/27/21, 15:47

    Reply

    Reverted the workspaceOl() call.
  11. core-ci voted on patch set 3 V +1 04/27/21, 15:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10740

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 04/27/21, 16:16

  13. Anja Leichsenring voted on patch set 3 V +1 CR +1 04/27/21, 16:53

  14. Benni Mack voted on patch set 3 V +2 CR +2 04/27/21, 17:23

  15. Benni Mack merged patch set 4 04/27/21, 17:23