Review main Merged

68888[BUGFIX] Use Address::create instead of new

Simon Gilli CR +2 V +2 Normal +89 −22 updated 05/03/21, 16:33

Commit message

The usage of Address::create instead of a plain new ensures
compatibility with all Symfony releases. Since Symfony 5.2.6 the
behavior was changed to always return email addresses properly
quoted but this change broke our Mailer.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1119

  1. Simon Gilli uploaded patch set 1 04/27/21, 18:27

  2. core-ci voted on patch set 1 V +1 04/27/21, 18:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10761

  3. Mathias Brodala updated the commit message in patch set 2 04/28/21, 06:40

  4. core-ci voted on patch set 2 V +1 04/28/21, 06:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10820

  5. Simon Gilli uploaded patch set 3 04/28/21, 09:27

  6. Simon Gilli updated the commit message in patch set 4 04/28/21, 09:33

  7. Simon Gilli updated the commit message in patch set 5 04/28/21, 09:35

  8. core-ci voted on patch set 3 V +1 04/28/21, 09:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10825

  9. core-ci voted on patch set 4 V +1 04/28/21, 09:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10826

  10. core-ci voted on patch set 5 V +1 04/28/21, 09:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10827

  11. Simon Gilli updated the commit message in patch set 6 04/29/21, 15:19

  12. core-ci voted on patch set 6 V +1 04/29/21, 15:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10913

  13. Christian Kuhn uploaded patch set 7 05/03/21, 10:44

  14. core-ci voted on patch set 7 V +1 05/03/21, 10:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11046

  15. core-ci commented on patch set 7 05/03/21, 11:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11047

  16. Christian Kuhn commented on patch set 7 V +1 CR +1 05/03/21, 11:51

    nightly green, so composer min&max should to, too: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11047
  17. Benni Mack voted on patch set 7 V +1 CR +1 05/03/21, 13:22

  18. Christian Kuhn voted on patch set 7 V +2 CR +2 05/03/21, 16:33

  19. Christian Kuhn merged patch set 8 05/03/21, 16:33